[GitHub] [incubator-openwhisk] upgle commented on a change in pull request #4211: Add `binding` annotation to record an action path not resolved

[GitBox <gi...@apache.org>]

upgle commented on a change in pull request #4211: Add `binding` annotation to record an action path not resolved
URL: https://github.com/apache/incubator-openwhisk/pull/4211#discussion_r266504033
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskActivation.scala
 ##########
 @@ -137,6 +137,7 @@ object WhiskActivation
 
   /** Some field names for annotations */
   val pathAnnotation = "path"
+  val bindingAnnotation = "binding"
 
 Review comment:
   I'm sorry, I don't understand this. 
   
   In the example below, I think the name `triple` in the activation can not be the name of the binding `whisk.system/p2`
   
   - there is an action `whisk.system/pkg1/triple`
   - and the `whisk.system/p2` is binding the `whisk.system/pkg1`
   - and i invoked an action `whisk.system/p2/triple`
   
   ```json
   {
       "namespace": "whisk.system",
       "name": "triple",
       "version": "0.0.1",
       "subject": "whisk.system",
       "activationId": "b86606b16b8a4371a606b16b8a437182",
       "start": 1552900408086,
       "end": 1552900408090,
       "duration": 4,
       "annotations": [
           {
               "key": "binding",
               "value": "whisk.system/p2"
           },
           {
               "key": "path",
               "value": "whisk.system/pkg1/triple"
           },
   ...
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services