You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:49:45 UTC
[GitHub] [incubator-tubemq] cku328 opened a new pull request #99: [TUBEMQ-159] Fix some typos
cku328 opened a new pull request #99:
URL: https://github.com/apache/incubator-tubemq/pull/99
I found some typos in TubeMQ code and fixed it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #99: [TUBEMQ-159] Fix some typos
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #99:
URL: https://github.com/apache/incubator-tubemq/pull/99
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] cku328 commented on pull request #99: [TUBEMQ-159] Fix some typos
Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #99:
URL: https://github.com/apache/incubator-tubemq/pull/99#issuecomment-634635638
Thanks @gosonzhang for the review and comments.
I also agree that modifying the external API parameter field is risky, and I re-checked my commit and how it relates to TubeMQ code.
I compared the differences between Chinese and English versions of the HTTP API Definition Guide (`docs/http_access_API_definition.md` and `docs/http_access_API_definition_cn.xls`).
From the Chinese version, I found that the parameter field should be "**allowedBClientRate**", and I verified from some code that this name is correct, like [this](https://github.com/apache/incubator-tubemq/blob/02220e747f4251fa4ddf0eef305bfad31648428e/tubemq-server/src/main/java/org/apache/tubemq/server/master/web/handler/WebAdminGroupCtrlHandler.java#L1237:L1238).
And the parameter field "**modfiyUser**", I also confirmed that it's just a typo in the document.
I updated my patch based on the above description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang commented on a change in pull request #99: [TUBEMQ-159] Fix some typos
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #99:
URL: https://github.com/apache/incubator-tubemq/pull/99#discussion_r430839141
##########
File path: docs/http_access_API_definition.md
##########
@@ -740,7 +740,7 @@ __Request__
|---|---|---|---|
|groupName|yes|the group name to set flow control rule|String|
|enableBind|no|whether to bind consuming permission, default value 0 means disable|int|
-|allowBCleintRatio|no|the ratio of the number of the consuming target's broker against the number of client in consuming group|int|
+|allowBClientRatio|no|the ratio of the number of the consuming target's broker against the number of client in consuming group|int|
Review comment:
This needs to be modified together with the external api parameters and configuration parameters, or will the document be inconsistent with the actual field
But after this modification, it will affect the already used business adjustments. How can it be compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org