You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/24 00:44:00 UTC
[jira] [Commented] (AIRFLOW-6516) Airflow Local Setting ConfigMap
overrides airflow.cfg VolumeMount
[ https://issues.apache.org/jira/browse/AIRFLOW-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043108#comment-17043108 ]
ASF GitHub Bot commented on AIRFLOW-6516:
-----------------------------------------
kaxil commented on pull request #7518: [AIRFLOW-6516] Allow different configmaps for airflow.cfg & airflow_l…
URL: https://github.com/apache/airflow/pull/7518
…ocal_settings.py (#7109)
https://github.com/apache/airflow/pull/7109 fixed a bug to allow airflow.cfg and airflow_local_settings.py to be specified in a configmap. However if someone wanted to use a different configmap for them, it would have resulted in an error **(Note I had already fixed this in the backport - https://github.com/apache/airflow/commit/adb409fd713d5c80c595d681d6a16f3ed892d5c2 and is already fixed in 1.10.8 and 1.10.9)**. This fix is for Airflow 2.0 and master
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Airflow Local Setting ConfigMap overrides airflow.cfg VolumeMount
> -----------------------------------------------------------------
>
> Key: AIRFLOW-6516
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6516
> Project: Apache Airflow
> Issue Type: Bug
> Components: core
> Affects Versions: 1.10.8
> Reporter: Kaxil Naik
> Assignee: Kaxil Naik
> Priority: Major
> Fix For: 1.10.8
>
>
> https://github.com/apache/airflow/commit/4748a518ced4ebd30caec2ac290c782ef023b0d7 introduced a bug because we were re-assigning the "airflow-config" key in volume_mounts/
> Because of this airflow.cfg was not mounted and only airflow_local_settings was mounted if the `airflow_local_settings_configmap` is also set.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)