You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/05 19:28:38 UTC
[GitHub] [superset] etr2460 opened a new pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
etr2460 opened a new pull request #17356:
URL: https://github.com/apache/superset/pull/17356
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
People commonly complain about accidentally navigating forwards or backwards in chrome when horizontally scrolling in SQL Lab. Most of our app doesn't have such a horizontal scrolling paradigm, but SQL Lab is the exception. So let's remove that horizontal scrolling navigation behavior in SQL Lab
### TESTING INSTRUCTIONS
Spin up a testenv and test
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962091180
Can we turn it off for the whole app? I hate that pattern! 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962009681
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-964684921
> @etr2460 @betodealmeida Table chart would need horizontal scrolling at least. Some other tables may also need it.
Oh, if I understood correctly we're not getting rid of horizontal scrolling (that's also needed in SQL Lab), but navigating between pages by using horizontal scrolling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jess-dillard commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
jess-dillard commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962108125
I'd need to do some research on the accessibility issues around turning it off for the entire app, but big thumbs up to doing it here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962045556
@etr2460 Ephemeral environment spinning up at http://18.236.74.45:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-961990763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-961990763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962011324
@etr2460 Ephemeral environment spinning up at http://52.35.144.201:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #17356:
URL: https://github.com/apache/superset/pull/17356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-964673886
@etr2460 @betodealmeida Table chart would need horizontal scrolling at least. Some other tables may also need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962023414
# [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17356](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2625e52) into [master](https://codecov.io/gh/apache/superset/commit/fa51b3234ed83a5f2910951f4cd2b1676a7b7d6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa51b32) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2625e52 differs from pull request most recent head 30cc709. Consider uploading reports for the commit 30cc709 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17356 +/- ##
=======================================
Coverage 77.06% 77.06%
=======================================
Files 1036 1036
Lines 55757 55757
Branches 7628 7628
=======================================
Hits 42969 42969
Misses 12532 12532
Partials 256 256
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.42% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa51b32...30cc709](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962011324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962023414
# [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17356](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2625e52) into [master](https://codecov.io/gh/apache/superset/commit/fa51b3234ed83a5f2910951f4cd2b1676a7b7d6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa51b32) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2625e52 differs from pull request most recent head 30cc709. Consider uploading reports for the commit 30cc709 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17356 +/- ##
=======================================
Coverage 77.06% 77.06%
=======================================
Files 1036 1036
Lines 55757 55757
Branches 7628 7628
=======================================
Hits 42969 42969
Misses 12532 12532
Partials 256 256
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.42% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa51b32...30cc709](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962091180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962042510
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jess-dillard commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
jess-dillard commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962108125
I'd need to do some research on the accessibility issues around turning it off for the entire app, but big thumbs up to doing it here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962027138
/testenv down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962099040
>Can we turn it off for the whole app? I hate that pattern! 😆
We can consider it, would appreciate a UX designer/PM's take on that first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-961990763
Marking as ready for review to get the docker build, will tag people when it's actually ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #17356:
URL: https://github.com/apache/superset/pull/17356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962023414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962011324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962111657
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #17356:
URL: https://github.com/apache/superset/pull/17356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jess-dillard commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
jess-dillard commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962108125
I'd need to do some research on the accessibility issues around turning it off for the entire app, but big thumbs up to doing it here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962023414
# [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17356](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2625e52) into [master](https://codecov.io/gh/apache/superset/commit/fa51b3234ed83a5f2910951f4cd2b1676a7b7d6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa51b32) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2625e52 differs from pull request most recent head cc98071. Consider uploading reports for the commit cc98071 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17356 +/- ##
=======================================
Coverage 77.06% 77.06%
=======================================
Files 1036 1036
Lines 55757 55757
Branches 7628 7628
=======================================
Hits 42969 42969
Misses 12532 12532
Partials 256 256
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.42% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa51b32...cc98071](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17356: fix: Remove horizontal scroll navigation from SQL Lab
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17356:
URL: https://github.com/apache/superset/pull/17356#issuecomment-962023414
# [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17356](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2625e52) into [master](https://codecov.io/gh/apache/superset/commit/fa51b3234ed83a5f2910951f4cd2b1676a7b7d6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa51b32) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 2625e52 differs from pull request most recent head 30cc709. Consider uploading reports for the commit 30cc709 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17356 +/- ##
=======================================
Coverage 77.06% 77.06%
=======================================
Files 1036 1036
Lines 55757 55757
Branches 7628 7628
=======================================
Hits 42969 42969
Misses 12532 12532
Partials 256 256
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.42% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa51b32...30cc709](https://codecov.io/gh/apache/superset/pull/17356?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org