You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Alibaba-HZY (via GitHub)" <gi...@apache.org> on 2023/08/17 07:55:58 UTC
[GitHub] [incubator-paimon] Alibaba-HZY opened a new pull request, #1837: [hive]hive create table should force primary key not null
Alibaba-HZY opened a new pull request, #1837:
URL: https://github.com/apache/incubator-paimon/pull/1837
hive create table should force primary key not null
### Tests
HiveCatalogITCaseBase
### API and Format
no
### Documentation
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] Alibaba-HZY commented on a diff in pull request #1837: [hive]hive create table should force primary key not null
Posted by "Alibaba-HZY (via GitHub)" <gi...@apache.org>.
Alibaba-HZY commented on code in PR #1837:
URL: https://github.com/apache/incubator-paimon/pull/1837#discussion_r1296857725
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java:
##########
@@ -146,7 +146,23 @@ public TableSchema createTable(Schema schema) throws Exception {
}
options.remove(CoreOptions.PRIMARY_KEY.key());
}
-
+ List<String> finalPrimaryKeys = primaryKeys;
+ fields =
Review Comment:
when hive create table primary key is created by
is not from Schema.normalizeFields
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi merged pull request #1837: [hive]hive create table should force primary key not null
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #1837:
URL: https://github.com/apache/incubator-paimon/pull/1837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1837: [hive]hive create table should force primary key not null
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1837:
URL: https://github.com/apache/incubator-paimon/pull/1837#discussion_r1296843929
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java:
##########
@@ -146,7 +146,23 @@ public TableSchema createTable(Schema schema) throws Exception {
}
options.remove(CoreOptions.PRIMARY_KEY.key());
}
-
+ List<String> finalPrimaryKeys = primaryKeys;
+ fields =
Review Comment:
Actually, I don't get why.
`Schema.normalizeFields` will convert pk fields to not-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1837: [hive]hive create table should force primary key not null
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #1837:
URL: https://github.com/apache/incubator-paimon/pull/1837#discussion_r1296912097
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java:
##########
@@ -146,7 +146,23 @@ public TableSchema createTable(Schema schema) throws Exception {
}
options.remove(CoreOptions.PRIMARY_KEY.key());
}
-
+ List<String> finalPrimaryKeys = primaryKeys;
+ fields =
Review Comment:
I see, maybe we should move the logical from `SchemaManager` to `Schema`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org