You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2013/03/10 06:09:32 UTC
svn commit: r1454789 - in /subversion/trunk/subversion: include/svn_repos.h
tests/libsvn_repos/repos-test.c
Author: stefan2
Date: Sun Mar 10 05:09:32 2013
New Revision: 1454789
URL: http://svn.apache.org/r1454789
Log:
The new (1.8) zero_copy_limit parameter in svn_repos_begin_report3
can only be used under certain circumstances. Document those.
Since we use that interface at our RA layers only, the preconditions
are fulfilled. However, our tests do some create things with this
API and this patch disables the zero copy optimization for those.
* subversion/include/svn_repos.h
(svn_repos_begin_report3): mention limitation on zero_copy_limit
* subversion/tests/libsvn_repos/repos-test.c
(reporter_depth_exclude): make our tests comply to that limitation
Modified:
subversion/trunk/subversion/include/svn_repos.h
subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
Modified: subversion/trunk/subversion/include/svn_repos.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_repos.h?rev=1454789&r1=1454788&r2=1454789&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_repos.h (original)
+++ subversion/trunk/subversion/include/svn_repos.h Sun Mar 10 05:09:32 2013
@@ -854,6 +854,10 @@ svn_repos_hooks_setenv(svn_repos_t *repo
* other clients may get blocked. Thus, be careful when using larger
* values here. 0 disables the optimization.
*
+ * @a note Never activate this optimization if @a editor might access
+ * any FSFS data structures (and, hence, caches). So, it is basically
+ * safe for networked editors only.
+ *
* All allocation for the context and collected state will occur in
* @a pool.
*
Modified: subversion/trunk/subversion/tests/libsvn_repos/repos-test.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_repos/repos-test.c?rev=1454789&r1=1454788&r2=1454789&view=diff
==============================================================================
--- subversion/trunk/subversion/tests/libsvn_repos/repos-test.c (original)
+++ subversion/trunk/subversion/tests/libsvn_repos/repos-test.c Sun Mar 10 05:09:32 2013
@@ -2630,7 +2630,7 @@ reporter_depth_exclude(const svn_test_op
SVN_ERR(svn_repos_begin_report3(&report_baton, 2, repos, "/", "", NULL,
TRUE, svn_depth_infinity, FALSE, FALSE,
- editor, edit_baton, NULL, NULL, 16,
+ editor, edit_baton, NULL, NULL, 0,
subpool));
SVN_ERR(svn_repos_set_path3(report_baton, "", 1,
svn_depth_infinity,
@@ -2688,7 +2688,7 @@ reporter_depth_exclude(const svn_test_op
SVN_ERR(svn_repos_begin_report3(&report_baton, 2, repos, "/", "", NULL,
TRUE, svn_depth_infinity, FALSE, FALSE,
- editor, edit_baton, NULL, NULL, 20,
+ editor, edit_baton, NULL, NULL, 0,
subpool));
SVN_ERR(svn_repos_set_path3(report_baton, "", 1,
svn_depth_infinity,