You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2008/04/24 14:29:44 UTC
svn commit: r651244 - in
/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear:
BigMatrixImpl.java RealMatrixImpl.java
Author: luc
Date: Thu Apr 24 05:29:41 2008
New Revision: 651244
URL: http://svn.apache.org/viewvc?rev=651244&view=rev
Log:
changed the field TOO_SMALL from protected to private static
Modified:
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
Modified: commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java?rev=651244&r1=651243&r2=651244&view=diff
==============================================================================
--- commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java (original)
+++ commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java Thu Apr 24 05:29:41 2008
@@ -73,7 +73,7 @@
private int scale = 64;
/** Bound to determine effective singularity in LU decomposition */
- protected static BigDecimal TOO_SMALL = new BigDecimal(10E-12);
+ private static final BigDecimal TOO_SMALL = new BigDecimal(10E-12);
/** BigDecimal 0 */
static final BigDecimal ZERO = new BigDecimal(0);
Modified: commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java?rev=651244&r1=651243&r2=651244&view=diff
==============================================================================
--- commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java (original)
+++ commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java Thu Apr 24 05:29:41 2008
@@ -69,7 +69,7 @@
private int parity = 1;
/** Bound to determine effective singularity in LU decomposition */
- protected static double TOO_SMALL = 10E-12;
+ private static final double TOO_SMALL = 10E-12;
/**
* Creates a matrix with no data
Re: svn commit: r651244 - in /commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear: BigMatrixImpl.java RealMatrixImpl.java
Posted by Phil Steitz <ph...@gmail.com>.
On Thu, Apr 24, 2008 at 6:45 AM, sebb <se...@gmail.com> wrote:
> 2008/4/24 <lu...@free.fr>:
>
> > This change is a little weird.
> >
> > We discussed about this field back in january
> > (http://markmail.org/message/45y6znvvg2ucauwa) and decided to deprecate it
> > before changing it to private static.
> >
> > We forgot to mark it deprecated while releasing 1.2.
> >
> > Since 2.0 will introduce other incompatible changes, I thought it was time to
> > make the change and went ahead with the modification. I feel uncomfortable with
> > this though, because users have not been warned about this (however, I'm not
> > sure anybody relied on the availability of this protected field).
> >
> > There is another change that bother me: we did not deprecate either the
> > UnivariateRealSolverFactory class and did not replace it by setter injection in
> > 1.2, as we have done for other algorithms.
> >
> > Do you think we should:
> > 1) revert the change and go back to a protected field, not
> > forgetting to mark it as deprecated and removing it in 3.0
> > 2) go ahead and only apologize about forgotten deprecation mark
> > (and also replace UnivariateRealSolverFactory in the same move)
> > 3) do a 1.3 release only in order to add the forgotten deprecation
> >
> > Choice 1 is the most conservative one, but means we will keep dirty code for a
> > long time. Choice 2 is my personal preference, it is rather rude but I think we
> > made a mistake and have to assume it. Choice 3 seems realistic only if we
> > release 1.3 very soon to let users take these deprecations onto account and wait
> > some time before 2.0, I don't like it because 2.0 is really badly needed for the
> > features it will bring.
>
> Upgrading from 1.2 to 2.0 is a major version change - seems to me that
> users should expect such changes.
> So long as the change is clearly documented, I don't see a problem, so
> I would support choice 2.
>
>
+1 for option 2.
Phil
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r651244 - in /commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear: BigMatrixImpl.java RealMatrixImpl.java
Posted by sebb <se...@gmail.com>.
2008/4/24 <lu...@free.fr>:
> This change is a little weird.
>
> We discussed about this field back in january
> (http://markmail.org/message/45y6znvvg2ucauwa) and decided to deprecate it
> before changing it to private static.
>
> We forgot to mark it deprecated while releasing 1.2.
>
> Since 2.0 will introduce other incompatible changes, I thought it was time to
> make the change and went ahead with the modification. I feel uncomfortable with
> this though, because users have not been warned about this (however, I'm not
> sure anybody relied on the availability of this protected field).
>
> There is another change that bother me: we did not deprecate either the
> UnivariateRealSolverFactory class and did not replace it by setter injection in
> 1.2, as we have done for other algorithms.
>
> Do you think we should:
> 1) revert the change and go back to a protected field, not
> forgetting to mark it as deprecated and removing it in 3.0
> 2) go ahead and only apologize about forgotten deprecation mark
> (and also replace UnivariateRealSolverFactory in the same move)
> 3) do a 1.3 release only in order to add the forgotten deprecation
>
> Choice 1 is the most conservative one, but means we will keep dirty code for a
> long time. Choice 2 is my personal preference, it is rather rude but I think we
> made a mistake and have to assume it. Choice 3 seems realistic only if we
> release 1.3 very soon to let users take these deprecations onto account and wait
> some time before 2.0, I don't like it because 2.0 is really badly needed for the
> features it will bring.
Upgrading from 1.2 to 2.0 is a major version change - seems to me that
users should expect such changes.
So long as the change is clearly documented, I don't see a problem, so
I would support choice 2.
> Luc
>
> Selon luc@apache.org:
>
>
>
> > Author: luc
> > Date: Thu Apr 24 05:29:41 2008
> > New Revision: 651244
> >
> > URL: http://svn.apache.org/viewvc?rev=651244&view=rev
> > Log:
> > changed the field TOO_SMALL from protected to private static
> >
> > Modified:
> >
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> >
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> >
> > Modified:
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> > URL:
> >
> http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java?rev=651244&r1=651243&r2=651244&view=diff
> > ==============================================================================
> > ---
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> > (original)
> > +++
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> > Thu Apr 24 05:29:41 2008
> > @@ -73,7 +73,7 @@
> > private int scale = 64;
> >
> > /** Bound to determine effective singularity in LU decomposition */
> > - protected static BigDecimal TOO_SMALL = new BigDecimal(10E-12);
> > + private static final BigDecimal TOO_SMALL = new BigDecimal(10E-12);
> >
> > /** BigDecimal 0 */
> > static final BigDecimal ZERO = new BigDecimal(0);
> >
> > Modified:
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> > URL:
> >
> http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java?rev=651244&r1=651243&r2=651244&view=diff
> > ==============================================================================
> > ---
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> > (original)
> > +++
> >
> commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> > Thu Apr 24 05:29:41 2008
> > @@ -69,7 +69,7 @@
> > private int parity = 1;
> >
> > /** Bound to determine effective singularity in LU decomposition */
> > - protected static double TOO_SMALL = 10E-12;
> > + private static final double TOO_SMALL = 10E-12;
> >
> > /**
> > * Creates a matrix with no data
> >
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r651244 - in /commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear: BigMatrixImpl.java RealMatrixImpl.java
Posted by lu...@free.fr.
This change is a little weird.
We discussed about this field back in january
(http://markmail.org/message/45y6znvvg2ucauwa) and decided to deprecate it
before changing it to private static.
We forgot to mark it deprecated while releasing 1.2.
Since 2.0 will introduce other incompatible changes, I thought it was time to
make the change and went ahead with the modification. I feel uncomfortable with
this though, because users have not been warned about this (however, I'm not
sure anybody relied on the availability of this protected field).
There is another change that bother me: we did not deprecate either the
UnivariateRealSolverFactory class and did not replace it by setter injection in
1.2, as we have done for other algorithms.
Do you think we should:
1) revert the change and go back to a protected field, not
forgetting to mark it as deprecated and removing it in 3.0
2) go ahead and only apologize about forgotten deprecation mark
(and also replace UnivariateRealSolverFactory in the same move)
3) do a 1.3 release only in order to add the forgotten deprecation
Choice 1 is the most conservative one, but means we will keep dirty code for a
long time. Choice 2 is my personal preference, it is rather rude but I think we
made a mistake and have to assume it. Choice 3 seems realistic only if we
release 1.3 very soon to let users take these deprecations onto account and wait
some time before 2.0, I don't like it because 2.0 is really badly needed for the
features it will bring.
Luc
Selon luc@apache.org:
> Author: luc
> Date: Thu Apr 24 05:29:41 2008
> New Revision: 651244
>
> URL: http://svn.apache.org/viewvc?rev=651244&view=rev
> Log:
> changed the field TOO_SMALL from protected to private static
>
> Modified:
>
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
>
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
>
> Modified:
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> URL:
>
http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java?rev=651244&r1=651243&r2=651244&view=diff
> ==============================================================================
> ---
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> (original)
> +++
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/BigMatrixImpl.java
> Thu Apr 24 05:29:41 2008
> @@ -73,7 +73,7 @@
> private int scale = 64;
>
> /** Bound to determine effective singularity in LU decomposition */
> - protected static BigDecimal TOO_SMALL = new BigDecimal(10E-12);
> + private static final BigDecimal TOO_SMALL = new BigDecimal(10E-12);
>
> /** BigDecimal 0 */
> static final BigDecimal ZERO = new BigDecimal(0);
>
> Modified:
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> URL:
>
http://svn.apache.org/viewvc/commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java?rev=651244&r1=651243&r2=651244&view=diff
> ==============================================================================
> ---
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> (original)
> +++
>
commons/proper/math/branches/MATH_2_0/src/java/org/apache/commons/math/linear/RealMatrixImpl.java
> Thu Apr 24 05:29:41 2008
> @@ -69,7 +69,7 @@
> private int parity = 1;
>
> /** Bound to determine effective singularity in LU decomposition */
> - protected static double TOO_SMALL = 10E-12;
> + private static final double TOO_SMALL = 10E-12;
>
> /**
> * Creates a matrix with no data
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org