You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/06 03:30:13 UTC
[GitHub] [tvm] zxybazh opened a new pull request, #12016: [MetaSchedule] Support ApplyHistoryBest Direct Dispatch
zxybazh opened a new pull request, #12016:
URL: https://github.com/apache/tvm/pull/12016
This PR introduced a new argument for `ApplyHistoryBest`'s `Query` interface to allow direct dispatch without querying the database, would be useful for debugging and benchmarking without interference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #12016: [MetaSchedule] Support ApplyHistoryBest Direct Dispatch
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged PR #12016:
URL: https://github.com/apache/tvm/pull/12016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12016: [MetaSchedule] Support ApplyHistoryBest Direct Dispatch
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on code in PR #12016:
URL: https://github.com/apache/tvm/pull/12016#discussion_r915210031
##########
python/tvm/meta_schedule/apply_history_best.py:
##########
@@ -85,8 +86,11 @@ def query(
Target Info
dispatched : Optional[List[IRModule]]
A list of low-level IRs that the high-level IR could potentially dispatch to
- f_take_tuning_record : Callable[[TuningRecord], None] = None
+ f_take_tuning_record : Optional[Callable[[TuningRecord], None]] = None
A callback function that takes a tuning record and does something with it
+ f_direct_dispatch : Optional[Callable[[IRModule], Optional[Schedule]]] = None
Review Comment:
Let's return `Optional[IRModule]` instead of `Optional[Schedule]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #12016: [MetaSchedule] Support ApplyHistoryBest Direct Dispatch
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #12016:
URL: https://github.com/apache/tvm/pull/12016#issuecomment-1177076145
let's fix the lint and get it in!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] zxybazh commented on pull request #12016: [MetaSchedule] Support ApplyHistoryBest Direct Dispatch
Posted by GitBox <gi...@apache.org>.
zxybazh commented on PR #12016:
URL: https://github.com/apache/tvm/pull/12016#issuecomment-1176730846
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org