You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/04 17:58:06 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1705: nRF52: refactor system timer handling; support tickless and nontickless using RTC/systick

xiaoxiang781216 edited a comment on pull request #1705:
URL: https://github.com/apache/incubator-nuttx/pull/1705#issuecomment-687296934


   > I'm just wondering if we shouldn't change the terminology related to RTC in the NRF52 family.
   > 
   > Nordic uses the term `RTC` to refer to a `Real Time Counter`, but industry standard refers to the RTC as `Real-Time Clock`.
   > They are different peripherals with different uses.
   > Names like `nrf52_rtc.c` or `nrf52_rtc_lowerhalf.c` are a bit confusing if we have some experience with other architectures.
   > 
   > We probably should change all RTC-related names to RTCTIM or something similar, so that it is immediately known that we're referring to a timer instance not a clock instance.
   > 
   > Of course, this is a topic for a separate PR, but I'm curious what do you think about it?
   
   The keypoint isn't whether the hardware save the time as a counter or as y/m/d/h/m/s/us, because it is very easy to convert between these two representation(mktime and gmtime_r). The major difference is whether the timer is in an always on domain, and never stop counting. If it's true, it's better to implement as rtc_lowerhalf_s, otherwise it should implement as oneshot_lowerhalf_s or timer_lowerhalf_s.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org