You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Oleg Tkachenko <ol...@multiconn.com> on 2002/11/06 13:12:29 UTC

awt viewer revisited

Hello there!

I have posted my awt viewer patch to the bugzilla patch queue. Please review. 
I tested the patch (english and russian languages only though) and it looks ok 
to me.
PS.A bit of nitpicking: "Images" catalog looks bizarre among other packages, 
should be "images".
-- 
Oleg Tkachenko
eXperanto team
Multiconn Technologies, Israel




---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: awt viewer revisited

Posted by Jeremias Maerki <de...@greenmail.ch>.
On Wed, 06 Nov 2002 23:59:53 +0200 Oleg Tkachenko wrote:
> Keiron Liddle wrote:
> 
> > I had a few problems with character encoding and line endings so check
> > that it is right. 
> The code looks fine, but all Viewer*.property files seem to be CRCRLF-ed 
> :( I have no idea why.

That's a problem all over the maintenance branch. If you have UltraEdit
it's easy to just load the file and make a conversion "UNIX --> DOS".
Sounds strange, but works fine here. That's the problem I described in
the "line ending chaos" thread.

Jeremias Maerki


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: awt viewer revisited

Posted by Oleg Tkachenko <ol...@multiconn.com>.
Keiron Liddle wrote:

> I had a few problems with character encoding and line endings so check
> that it is right. 
The code looks fine, but all Viewer*.property files seem to be CRCRLF-ed 
:( I have no idea why.

-- 
Oleg Tkachenko
eXperanto team
Multiconn Technologies, Israel


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: awt viewer revisited

Posted by Keiron Liddle <ke...@aftexsw.com>.
On Wed, 2002-11-06 at 14:45, Keiron Liddle wrote:
> On Wed, 2002-11-06 at 13:12, Oleg Tkachenko wrote:
> > Hello there!
> > 
> > I have posted my awt viewer patch to the bugzilla patch queue. Please review. 
> > I tested the patch (english and russian languages only though) and it looks ok 
> > to me.
> 
> Great! I'll take a look at see it in action.

Looks good.

I'll commit that.

I had a few problems with character encoding and line endings so check
that it is right. But it is good to see that the properties are in
unicode now.


Keiron.



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org


Re: awt viewer revisited

Posted by Keiron Liddle <ke...@aftexsw.com>.
On Wed, 2002-11-06 at 13:12, Oleg Tkachenko wrote:
> Hello there!
> 
> I have posted my awt viewer patch to the bugzilla patch queue. Please review. 
> I tested the patch (english and russian languages only though) and it looks ok 
> to me.

Great! I'll take a look at see it in action.

> PS.A bit of nitpicking: "Images" catalog looks bizarre among other packages, 
> should be "images".

I think the java standard is packages are always lower case, so it is
wrong. A bit difficult to change as some OS's can't handle case in
directories.

Keiron


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org