You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/09/07 20:26:55 UTC

Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-3379
    https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
-------

Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.


Diffs
-----

  src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 

Diff: https://reviews.apache.org/r/38164/diff/


Testing
-------

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose


Thanks,

haosdent huang


Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review101420
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38164]

All tests passed.

- Mesos ReviewBot


On Oct. 3, 2015, 4:17 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 4:17 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: MESOS-3379
>     https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> -------
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/
-----------------------------------------------------------

(Updated Oct. 3, 2015, 4:17 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
-------

Rebase


Bugs: MESOS-3379
    https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
-------

Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.


Diffs (updated)
-----

  src/slave/containerizer/isolators/filesystem/linux.cpp 8823b7850a1ac17fc4f4868aadf1b04428d2381b 

Diff: https://reviews.apache.org/r/38164/diff/


Testing
-------

sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose


Thanks,

haosdent huang


Re: Review Request 38164: Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38164/#review97941
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38164]

All tests passed.

- Mesos ReviewBot


On Sept. 7, 2015, 6:26 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38164/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3379
>     https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use reverse umount order in LinuxFilesystemIsolatorProcess::cleanup.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9 
> 
> Diff: https://reviews.apache.org/r/38164/diff/
> 
> 
> Testing
> -------
> 
> sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="LinuxFilesystemIsolatorTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>