You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2023/06/19 08:41:06 UTC

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20090


Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................

IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

This bumps the ORC C++ version from 1.7.0-p14 to 1.7.9-p10 to add the
fixes of ORC-1041 and ORC-1304.

Tests:
 - Add e2e test for ORC-1304.
 - It's hard to add test for ORC-1041 since it won't cause crashes when
   compiling with gcc-10.

Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
---
M bin/impala-config.sh
M testdata/data/README
A testdata/data/empty_present_stream.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test
6 files changed, 71 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/20090/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1:

Thanks for the quick review!


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 05:03:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13331/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 09:04:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1: Code-Review+2

This looks good to me


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 02:53:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9412/


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 08:14:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 10:24:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9412/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 02:52:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9414/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2023 05:03:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20090 )

Change subject: IMPALA-12128: Bump ORC C++ version to 1.7.9-p10
......................................................................

IMPALA-12128: Bump ORC C++ version to 1.7.9-p10

This bumps the ORC C++ version from 1.7.0-p14 to 1.7.9-p10 to add the
fixes of ORC-1041 and ORC-1304.

Tests:
 - Add e2e test for ORC-1304.
 - It's hard to add test for ORC-1041 since it won't cause crashes when
   compiling with gcc-10.

Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Reviewed-on: http://gerrit.cloudera.org:8080/20090
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M testdata/data/README
A testdata/data/empty_present_stream.orc
M testdata/datasets/functional/functional_schema_template.sql
M testdata/datasets/functional/schema_constraints.csv
M testdata/workloads/functional-query/queries/QueryTest/orc-stats.test
6 files changed, 71 insertions(+), 3 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I26c39fe5b15ab0bcbe6b2af6fe7a45e48eaec6eb
Gerrit-Change-Number: 20090
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>