You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2020/10/06 06:12:48 UTC
Re: Review Request 72883: RANGER-3001:Update Ranger KafkaClient to
use Kafka AdminClient API instead of Zookeeper
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72883/
-----------------------------------------------------------
(Updated Oct. 6, 2020, 6:12 a.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, and Madhan Neethiraj.
Changes
-------
Added error handing
Bugs: RANGER-3001
https://issues.apache.org/jira/browse/RANGER-3001
Repository: ranger
Description
-------
RANGER-3001:Update Ranger KafkaClient to use Kafka AdminClient API instead of Zookeeper
Diffs (updated)
-----
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java 91a7d27dd
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java 9e0d6b4c0
Diff: https://reviews.apache.org/r/72883/diff/2/
Changes: https://reviews.apache.org/r/72883/diff/1-2/
Testing
-------
Verify in local cluster for lookup and test functionality
- Kafka Service in Ranger has to have the following configs define for this to work.
bootstrap.servers = host1:9092,host2:9092,host3:9092
security.protocol = SASL_PLAINTEXT
sasl.mechanism = GSSAPI
kafka.keytab = <keytab for kafka principal>
kafka.principal = <pr...@domainname>
Thanks,
Ramesh Mani
Re: Review Request 72883: RANGER-3001:Update Ranger KafkaClient to
use Kafka AdminClient API instead of Zookeeper
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72883/#review222015
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On Oct. 6, 2020, 6:12 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72883/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2020, 6:12 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, and Madhan Neethiraj.
>
>
> Bugs: RANGER-3001
> https://issues.apache.org/jira/browse/RANGER-3001
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3001:Update Ranger KafkaClient to use Kafka AdminClient API instead of Zookeeper
>
>
> Diffs
> -----
>
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java 91a7d27dd
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java 9e0d6b4c0
>
>
> Diff: https://reviews.apache.org/r/72883/diff/2/
>
>
> Testing
> -------
>
> Verify in local cluster for lookup and test functionality
>
> - Kafka Service in Ranger has to have the following configs define for this to work.
>
> bootstrap.servers = host1:9092,host2:9092,host3:9092
> security.protocol = SASL_PLAINTEXT
> sasl.mechanism = GSSAPI
> kafka.keytab = <keytab for kafka principal>
> kafka.principal = <pr...@domainname>
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72883: RANGER-3001:Update Ranger KafkaClient to
use Kafka AdminClient API instead of Zookeeper
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72883/#review222022
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 12, 2020, 4:21 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72883/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2020, 4:21 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, and Madhan Neethiraj.
>
>
> Bugs: RANGER-3001
> https://issues.apache.org/jira/browse/RANGER-3001
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3001:Update Ranger KafkaClient to use Kafka AdminClient API instead of Zookeeper
>
>
> Diffs
> -----
>
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java 91a7d27dd
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java 9e0d6b4c0
>
>
> Diff: https://reviews.apache.org/r/72883/diff/3/
>
>
> Testing
> -------
>
> Verify in local cluster for lookup and test functionality
>
> - Kafka Service in Ranger has to have the following configs define for this to work.
>
> bootstrap.servers = host1:9092,host2:9092,host3:9092
> security.protocol = SASL_PLAINTEXT
> sasl.mechanism = GSSAPI
> kafka.keytab = <keytab for kafka principal>
> kafka.principal = <pr...@domainname>
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 72883: RANGER-3001:Update Ranger KafkaClient to
use Kafka AdminClient API instead of Zookeeper
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72883/
-----------------------------------------------------------
(Updated Oct. 12, 2020, 4:21 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, and Madhan Neethiraj.
Changes
-------
Fixed review comments
Bugs: RANGER-3001
https://issues.apache.org/jira/browse/RANGER-3001
Repository: ranger
Description
-------
RANGER-3001:Update Ranger KafkaClient to use Kafka AdminClient API instead of Zookeeper
Diffs (updated)
-----
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java 91a7d27dd
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java 9e0d6b4c0
Diff: https://reviews.apache.org/r/72883/diff/3/
Changes: https://reviews.apache.org/r/72883/diff/2-3/
Testing
-------
Verify in local cluster for lookup and test functionality
- Kafka Service in Ranger has to have the following configs define for this to work.
bootstrap.servers = host1:9092,host2:9092,host3:9092
security.protocol = SASL_PLAINTEXT
sasl.mechanism = GSSAPI
kafka.keytab = <keytab for kafka principal>
kafka.principal = <pr...@domainname>
Thanks,
Ramesh Mani
Re: Review Request 72883: RANGER-3001:Update Ranger KafkaClient to
use Kafka AdminClient API instead of Zookeeper
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72883/#review222020
-----------------------------------------------------------
plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java
Line 29 (original), 34 (patched)
<https://reviews.apache.org/r/72883/#comment311096>
Please consider having this function return an error string rather than throwing an exception. Something like:
String getServiceConfigValidationErrors(Map<String, String> configs);
and throw Exception with error string if return is not null.
- Abhay Kulkarni
On Oct. 6, 2020, 6:12 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72883/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2020, 6:12 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, and Madhan Neethiraj.
>
>
> Bugs: RANGER-3001
> https://issues.apache.org/jira/browse/RANGER-3001
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3001:Update Ranger KafkaClient to use Kafka AdminClient API instead of Zookeeper
>
>
> Diffs
> -----
>
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaClient.java 91a7d27dd
> plugin-kafka/src/main/java/org/apache/ranger/services/kafka/client/ServiceKafkaConnectionMgr.java 9e0d6b4c0
>
>
> Diff: https://reviews.apache.org/r/72883/diff/2/
>
>
> Testing
> -------
>
> Verify in local cluster for lookup and test functionality
>
> - Kafka Service in Ranger has to have the following configs define for this to work.
>
> bootstrap.servers = host1:9092,host2:9092,host3:9092
> security.protocol = SASL_PLAINTEXT
> sasl.mechanism = GSSAPI
> kafka.keytab = <keytab for kafka principal>
> kafka.principal = <pr...@domainname>
>
>
> Thanks,
>
> Ramesh Mani
>
>