You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "senn (via GitHub)" <gi...@apache.org> on 2024/08/22 15:18:18 UTC
[PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
senn opened a new pull request, #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41
I changed it so a collection reference is always constructed from scratch. Less performant but it seems to work.
All tests succeed and my example test demonstrating the inconsistent sorting (https://github.com/senn/aemcontext-no-serviceranking-ordering/blob/incorrect-ordering-depending-on-injection-time/src/test/java/com/github/senn/services/InjectionTimeOrderingTest.java) also succeeds if i build this locally and change the osgi-mock version to 3.5.1-SNAPSHOT in that project.
I'm no expert in OSGi bundlecontext / service registration so it needs a good thinking through and review.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41#issuecomment-2305197403
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41) **Quality Gate passed**
Issues
 [7 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
Posted by "henrykuijpers (via GitHub)" <gi...@apache.org>.
henrykuijpers merged PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41#issuecomment-2305010076
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
Posted by "henrykuijpers (via GitHub)" <gi...@apache.org>.
henrykuijpers commented on PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41#issuecomment-2307095089
Looks good, thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41#issuecomment-2305125795
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41) **Quality Gate passed**
Issues
 [5 New issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-osgi-mock&pullRequest=41)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12413: Keep sorting consistent in collection references whenever services are registered [sling-org-apache-sling-testing-osgi-mock]
Posted by "stefanseifert (via GitHub)" <gi...@apache.org>.
stefanseifert commented on PR #41:
URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/41#issuecomment-2307162435
this got merged fast - i have a couple of cosmetic but relevant complaints:
* the PR got merged in 3 single commits to the master branch - without any reference to the ticket number. preferred is to squash the PR when merging, and making sure that the commit message always starts with the ticket number
* sonar reports a couple of open issues e.g. unused code -that should be resolved first. although there may be a lot of unresolved warnings in existing old code, we should to introduce new ones, or add annotations where the warning is not appropriate with a comment why.
hopefully the approach to recreate the new collection on scratch does not come with a performance penalty for larger projects. but implementing it without that approach would require some more refactoring to support the different collection types and collection contents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org