You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/02/01 14:04:53 UTC

[GitHub] [kylin] shaofengshi opened a new pull request #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

shaofengshi opened a new pull request #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581036359
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=h1) Report
   > Merging [#1088](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/147109e72fbe52e7a8ce0dce4bbf0d7779249937?src=pr&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1088/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1088      +/-   ##
   ============================================
   - Coverage     25.05%   25.04%   -0.02%     
     Complexity     6224     6224              
   ============================================
     Files          1440     1442       +2     
     Lines         87819    87858      +39     
     Branches      12275    12285      +10     
   ============================================
     Hits          22001    22001              
   - Misses        63660    63699      +39     
     Partials       2158     2158
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.32% <0%> (-0.02%)` | `44 <0> (ø)` | |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.51% <0%> (-0.35%)` | `4 <0> (ø)` | |
   | [...in/measure/bitmap/BitmapIntersectValueAggFunc.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwSW50ZXJzZWN0VmFsdWVBZ2dGdW5jLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...e/kylin/measure/bitmap/RetentionPartialResult.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvUmV0ZW50aW9uUGFydGlhbFJlc3VsdC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...re/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwSW50ZXJzZWN0RGlzdGluY3RDb3VudEFnZ0Z1bmMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   | [...ylin/rest/controller/ExternalFilterController.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9FeHRlcm5hbEZpbHRlckNvbnRyb2xsZXIuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
   | [...cube/v2/coprocessor/endpoint/CubeVisitService.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL2NvcHJvY2Vzc29yL2VuZHBvaW50L0N1YmVWaXNpdFNlcnZpY2UuamF2YQ==) | `67.75% <0%> (ø)` | `16% <0%> (ø)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=footer). Last update [147109e...166c463](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581035953
 
 
   ## Pull Request Test Coverage Report for [Build 5591](https://coveralls.io/builds/28513904)
   
   * **0** of **66**   **(0.0%)**  changed or added relevant lines in **6** files are covered.
   * **8** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.02%**) to **27.517%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/28513904/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L2463) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://coveralls.io/builds/28513904/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectDistinctCountAggFunc.java#L51) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28513904/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L182) | 0 | 2 | 0.0%
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/28513904/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L600) | 0 | 3 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectValueAggFunc.java](https://coveralls.io/builds/28513904/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectValueAggFunc.java#L30) | 0 | 7 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RetentionPartialResult.java](https://coveralls.io/builds/28513904/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FRetentionPartialResult.java#L34) | 0 | 52 | 0.0%
   <!-- | **Total:** | **0** | **66** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://coveralls.io/builds/28513904/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectDistinctCountAggFunc.java#L38) | 1 | 0% |
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/28513904/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L603) | 1 | 0% |
   | [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/28513904/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28513904/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   <!-- | **Total:** | **8** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28513904/badge)](https://coveralls.io/builds/28513904) |
   | :-- | --: |
   | Change from base [Build 5590](https://coveralls.io/builds/28513272): |  -0.02% |
   | Covered Lines: | 24184 |
   | Relevant Lines: | 87889 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lgtm-com[bot] commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581778767
 
 
   This pull request **introduces 2 alerts** when merging f7ace48a0dedd1309b09b28c4a02d1fc7c0129fa into 6e7c33d1fa6992467a8eeb94113c30add79cb105 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-c97f4c2abb85d35bc7320f9d8d92435beb37c21f)
   
   **new alerts:**
   
   * 1 for Useless comparison test
   * 1 for Container size compared to zero

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581036359
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=h1) Report
   > Merging [#1088](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/147109e72fbe52e7a8ce0dce4bbf0d7779249937?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1088/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1088      +/-   ##
   ============================================
   + Coverage     25.05%   25.05%   +<.01%     
   + Complexity     6224     6223       -1     
   ============================================
     Files          1440     1440              
     Lines         87819    87830      +11     
     Branches      12275    12275              
   ============================================
   + Hits          22001    22006       +5     
   - Misses        63660    63666       +6     
     Partials       2158     2158
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.34% <0%> (ø)` | `44 <0> (ø)` | :arrow_down: |
   | [...n/java/org/apache/kylin/tool/CubeMigrationCLI.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9DdWJlTWlncmF0aW9uQ0xJLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...ylin/rest/controller/ExternalFilterController.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9FeHRlcm5hbEZpbHRlckNvbnRyb2xsZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...rg/apache/kylin/metadata/TableMetadataManager.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvVGFibGVNZXRhZGF0YU1hbmFnZXIuamF2YQ==) | `58.2% <50%> (ø)` | `26 <0> (ø)` | :arrow_down: |
   | [.../org/apache/kylin/metadata/model/TableExtDesc.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVFeHREZXNjLmphdmE=) | `59.82% <53.57%> (+0.5%)` | `14 <3> (ø)` | :arrow_down: |
   | [...ava/org/apache/kylin/metadata/model/TableDesc.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvbW9kZWwvVGFibGVEZXNjLmphdmE=) | `47.64% <63.63%> (+0.77%)` | `27 <0> (ø)` | :arrow_down: |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
   | [...cube/v2/coprocessor/endpoint/CubeVisitService.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9jdWJlL3YyL2NvcHJvY2Vzc29yL2VuZHBvaW50L0N1YmVWaXNpdFNlcnZpY2UuamF2YQ==) | `67.75% <0%> (ø)` | `16% <0%> (ø)` | :arrow_down: |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=footer). Last update [147109e...3842a08](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lgtm-com[bot] commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581091226
 
 
   This pull request **introduces 2 alerts** when merging 3842a08777ea40dd582277df7345c006ce790f39 into 33c9f7528e886b1df0ab739648f6ae30bc5c979b - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-6883bbe79e929f2809672995168bf9692145a470)
   
   **new alerts:**
   
   * 1 for Useless comparison test
   * 1 for Container size compared to zero

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] lgtm-com[bot] commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581037580
 
 
   This pull request **introduces 2 alerts** when merging 166c463e8d045b58e8d20d3743faa61ec849abb8 into 26cf1f8ed217c96329d8dcbd8a00ef1d67023fca - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-4f00a16a541faca05dae42ea57e6e545c5b24113)
   
   **new alerts:**
   
   * 1 for Useless comparison test
   * 1 for Container size compared to zero

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581035953
 
 
   ## Pull Request Test Coverage Report for [Build 5575](https://coveralls.io/builds/28477037)
   
   * **0** of **69**   **(0.0%)**  changed or added relevant lines in **8** files are covered.
   * **91** unchanged lines in **5** files lost coverage.
   * Overall coverage increased (+**0.03%**) to **27.538%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/28477037/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L2463) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectDistinctCountAggFunc.java#L51) | 0 | 1 | 0.0%
   | [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java](https://coveralls.io/builds/28477037/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkExecutable.java#L248) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L182) | 0 | 2 | 0.0%
   | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/28477037/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L257) | 0 | 2 | 0.0%
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/28477037/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L600) | 0 | 3 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectValueAggFunc.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectValueAggFunc.java#L30) | 0 | 7 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RetentionPartialResult.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FRetentionPartialResult.java#L34) | 0 | 52 | 0.0%
   <!-- | **Total:** | **0** | **69** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/28477037/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectDistinctCountAggFunc.java#L38) | 1 | 0% |
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/28477037/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L603) | 1 | 0% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableExtDesc.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableExtDesc.java#L78) | 23 | 62.39% |
   | [core-metadata/src/main/java/org/apache/kylin/metadata/model/TableDesc.java](https://coveralls.io/builds/28477037/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fmodel%2FTableDesc.java#L67) | 65 | 53.53% |
   <!-- | **Total:** | **91** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28477037/badge)](https://coveralls.io/builds/28477037) |
   | :-- | --: |
   | Change from base [Build 5570](https://coveralls.io/builds/28468475): |  0.03% |
   | Covered Lines: | 24168 |
   | Relevant Lines: | 87763 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen merged pull request #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581035953
 
 
   ## Pull Request Test Coverage Report for [Build 5574](https://coveralls.io/builds/28471741)
   
   * **0** of **66**   **(0.0%)**  changed or added relevant lines in **6** files are covered.
   * **7** unchanged lines in **3** files lost coverage.
   * Overall coverage decreased (**-0.009%**) to **27.501%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/28471741/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L2463) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://coveralls.io/builds/28471741/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectDistinctCountAggFunc.java#L51) | 0 | 1 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapMeasureType.java](https://coveralls.io/builds/28471741/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapMeasureType.java#L182) | 0 | 2 | 0.0%
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/28471741/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L600) | 0 | 3 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectValueAggFunc.java](https://coveralls.io/builds/28471741/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectValueAggFunc.java#L30) | 0 | 7 | 0.0%
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/RetentionPartialResult.java](https://coveralls.io/builds/28471741/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FRetentionPartialResult.java#L34) | 0 | 52 | 0.0%
   <!-- | **Total:** | **0** | **66** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-metadata/src/main/java/org/apache/kylin/measure/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://coveralls.io/builds/28471741/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbitmap%2FBitmapIntersectDistinctCountAggFunc.java#L38) | 1 | 0% |
   | [core-storage/src/main/java/org/apache/kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://coveralls.io/builds/28471741/source?filename=core-storage%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fgtrecord%2FGTCubeStorageQueryBase.java#L603) | 1 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28471741/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439) | 5 | 77.81% |
   <!-- | **Total:** | **7** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28471741/badge)](https://coveralls.io/builds/28471741) |
   | :-- | --: |
   | Change from base [Build 5570](https://coveralls.io/builds/28468475): |  -0.009% |
   | Covered Lines: | 24162 |
   | Relevant Lines: | 87858 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1088: KYLIN-4314 extend intersect_count and add intersect_value UDAF
URL: https://github.com/apache/kylin/pull/1088#issuecomment-581036359
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=h1) Report
   > Merging [#1088](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/147109e72fbe52e7a8ce0dce4bbf0d7779249937?src=pr&el=desc) will **increase** coverage by `0.02%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1088/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1088      +/-   ##
   ============================================
   + Coverage     25.05%   25.07%   +0.02%     
     Complexity     6224     6224              
   ============================================
     Files          1440     1440              
     Lines         87819    87763      -56     
     Branches      12275    12278       +3     
   ============================================
   + Hits          22001    22008       +7     
   + Misses        63660    63598      -62     
   + Partials       2158     2157       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/kylin/engine/spark/SparkExecutable.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtFeGVjdXRhYmxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `12.32% <0%> (-0.02%)` | `44 <0> (ø)` | |
   | [...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==) | `18.51% <0%> (-0.35%)` | `4 <0> (ø)` | |
   | [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `7.76% <0%> (+1.06%)` | `4 <0> (ø)` | :arrow_down: |
   | [...in/measure/bitmap/BitmapIntersectValueAggFunc.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwSW50ZXJzZWN0VmFsdWVBZ2dGdW5jLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...e/kylin/measure/bitmap/RetentionPartialResult.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvUmV0ZW50aW9uUGFydGlhbFJlc3VsdC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...re/bitmap/BitmapIntersectDistinctCountAggFunc.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwSW50ZXJzZWN0RGlzdGluY3RDb3VudEFnZ0Z1bmMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...kylin/storage/gtrecord/GTCubeStorageQueryBase.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0dUQ3ViZVN0b3JhZ2VRdWVyeUJhc2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `74.41% <0%> (-2.33%)` | `12% <0%> (ø)` | |
   | ... and [8 more](https://codecov.io/gh/apache/kylin/pull/1088/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=footer). Last update [147109e...3842a08](https://codecov.io/gh/apache/kylin/pull/1088?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services