[jira] [Commented] (BIGTOP-1725) Exclude null values from BOM json output added in BIGTOP-1718

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359265#comment-14359265 ] 

Konstantin Boudnik commented on BIGTOP-1725:
--------------------------------------------

Thanks for the patch!

Would it be more appropriate to put this functionality into BuildUtils instead of inlining it with the packaging build?
Also, considering that you're only trying to make JSON output prettier perhaps it'd make sense to denull it output when JSON is prepared? Thoughts?

> Exclude null values from BOM json output added in BIGTOP-1718
> -------------------------------------------------------------
>
>                 Key: BIGTOP-1725
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1725
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: general
>    Affects Versions: 0.8.0
>            Reporter: Jonathan Kelly
>            Assignee: Jonathan Kelly
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: 0001-exclude-null-values-from-BOM-json-output.patch, BIGTOP-1725.patch
>
>
> BIGTOP-1718 added support for a new bom-json task that outputs the BOM in json format, but the original format would include all possible fields with nulls for missing fields.  This patch removes all fields with null values in order to make the output cleaner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)