You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/23 02:09:27 UTC

[GitHub] [tvm] roger-zhao opened a new issue #7155: Potential bug for SearchSpace length 

roger-zhao opened a new issue #7155:
URL: https://github.com/apache/tvm/issues/7155


   https://github.com/apache/tvm/blob/08a69d4f92742c8c526d6a7c2a5805d00f5dc725/python/tvm/autotvm/task/space.py#L839
   
   here, when _length is None, then initiate it to current search space length, it's almost good most of times, however if user/developer get __len__ of search space when space is empty, then a unreasonable _length 1 will be produced( the result of empty list for np.prod is 1), so it's better for adding an extra condition such as " len(self.space_map.values()) != 0" . :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on issue #7155: Potential bug for SearchSpace length

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #7155:
URL: https://github.com/apache/tvm/issues/7155#issuecomment-752770806


   Closed via #7175 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 closed issue #7155: Potential bug for SearchSpace length

Posted by GitBox <gi...@apache.org>.
junrushao1994 closed issue #7155:
URL: https://github.com/apache/tvm/issues/7155


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] roger-zhao commented on issue #7155: Potential bug for SearchSpace length

Posted by GitBox <gi...@apache.org>.
roger-zhao commented on issue #7155:
URL: https://github.com/apache/tvm/issues/7155#issuecomment-750713910


   @comaniac No problem!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on issue #7155: Potential bug for SearchSpace length

Posted by GitBox <gi...@apache.org>.
comaniac commented on issue #7155:
URL: https://github.com/apache/tvm/issues/7155#issuecomment-750415923


   Thanks for the proposal. Could you send a PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org