You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/09 12:47:27 UTC
[GitHub] flink pull request #4504: [FLINK-7395] [metrics] Count bytesIn/Out without s...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4504
[FLINK-7395] [metrics] Count bytesIn/Out without synchronization
## What is the purpose of the change
This PR changes the numBytesIn/Out measurement to not use the synchronized `Buffer#getSize()` method.
## Brief change log
- Add unsynchronized ´Buffer#getSizeUnsafe()`
- replace all calls by the metric system to `Buffer#getSize()`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes (technically it's per-buffer, but i guess that still counts)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7395
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4504
----
commit c6f566916aab4b74b6437b6a153a189c6e17e793
Author: zentol <ch...@apache.org>
Date: 2017-08-09T12:43:51Z
[FLINK-7395] [metrics] Count bytesIn/Out without synchronization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4504: [FLINK-7395] [metrics] Count bytesIn/Out without synchron...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4504
@NicoK The byte counting in the ResultPartition class looks unrelated to the metric system; in fact that field isn't read anywhere. We may want to remove it, but I wouldn't do that as part of this PR.
---
[GitHub] flink issue #4504: [FLINK-7395] [metrics] Count bytesIn/Out without synchron...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4504
@twalthr noticed it and found it odd that we acquire a lock for doing metrics stuff, and asked me whether it is correct.
Since we try to keep the overhead of metrics as low as possible not acquiring this look seems sensible. It also ties in to the convention of not acquiring locks that are necessary for the job progress.
I may have been to quick with marking it as a blocker though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4504: [FLINK-7395] [metrics] Count bytesIn/Out without s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4504
---
[GitHub] flink issue #4504: [FLINK-7395] [metrics] Count bytesIn/Out without synchron...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4504
or, we may add these fields as a metric, actually - but let's discuss this elsewhere
---
[GitHub] flink issue #4504: [FLINK-7395] [metrics] Count bytesIn/Out without synchron...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4504
@zentol what is the root cause for this change? I see that this is marked as a blocker bug. Was this reported or discussed on the mailing list?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---