You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/22 15:02:03 UTC
[GitHub] [pulsar-helm-chart] naveen1100 opened a new pull request #64: changed publishNotReadyAddresses to service spec from annotation
naveen1100 opened a new pull request #64:
URL: https://github.com/apache/pulsar-helm-chart/pull/64
### Motivation
* ```publishNotReadyAddresses``` is a service spec and not a service annotation. This is mentioned in the K8s API docs at https://v1-17.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#servicespec-v1-core
### Modifications
* Modified ```publishNotReadyAddresses``` from annotation to service spec
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] naveen1100 commented on pull request #64: changed publishNotReadyAddresses to service spec from annotation
Posted by GitBox <gi...@apache.org>.
naveen1100 commented on pull request #64:
URL: https://github.com/apache/pulsar-helm-chart/pull/64#issuecomment-699867500
I really appreciate if someone can review this PR. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] jiazhai commented on pull request #64: changed publishNotReadyAddresses to service spec from annotation
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #64:
URL: https://github.com/apache/pulsar-helm-chart/pull/64#issuecomment-709085898
@zymap @wolfstudy Would you please also help review this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] wolfstudy merged pull request #64: changed publishNotReadyAddresses to service spec from annotation
Posted by GitBox <gi...@apache.org>.
wolfstudy merged pull request #64:
URL: https://github.com/apache/pulsar-helm-chart/pull/64
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org