You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "fabriziofortino (via GitHub)" <gi...@apache.org> on 2025/10/28 08:50:25 UTC

[PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

fabriziofortino opened a new pull request, #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2469198855


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -700,6 +700,8 @@ private ObjectBuilder<BoolQuery> inferenceConfigQuery(BoolQuery.Builder b, Strin
                         KnnQuery.Builder knnQueryBuilder = new KnnQuery.Builder();
                         knnQueryBuilder.field(InferenceConstants.VECTOR_SPACES + "." + inferenceModelConfigName + "." + InferenceConstants.VECTOR);
                         knnQueryBuilder.numCandidates(inferenceModelConfig.getNumCandidates());
+                        // see https://github.com/elastic/elasticsearch/pull/118774
+                        knnQueryBuilder.k(inferenceModelConfig.getNumCandidates());

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2470303924


##########
oak-search-elastic/pom.xml:
##########
@@ -33,8 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.java.client.version>8.18.2</elasticsearch.java.client.version>
-    <lucene.version>9.12.1</lucene.version>
+    <elasticsearch.java.client.version>8.19.5</elasticsearch.java.client.version>

Review Comment:
   I think we can continue to include lucene 9. The analyzers are compatible. We won't get new analyzers introduced from version 10.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2470282137


##########
oak-search-elastic/pom.xml:
##########
@@ -33,8 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.java.client.version>8.18.2</elasticsearch.java.client.version>
-    <lucene.version>9.12.1</lucene.version>
+    <elasticsearch.java.client.version>8.19.5</elasticsearch.java.client.version>

Review Comment:
   Just noticed that the analyzer package depends on the core. It won't work then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2470356338


##########
oak-search-elastic/pom.xml:
##########
@@ -33,8 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.java.client.version>8.18.2</elasticsearch.java.client.version>
-    <lucene.version>9.12.1</lucene.version>
+    <elasticsearch.java.client.version>8.19.5</elasticsearch.java.client.version>

Review Comment:
   actually, ES 8.19.5 depends on lucene 9.12.2. Just fixed the version.
   We are planning to upgrade to ES 9.x in the next month. We will use the above strategy then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2470266134


##########
oak-search-elastic/pom.xml:
##########
@@ -33,8 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.java.client.version>8.18.2</elasticsearch.java.client.version>
-    <lucene.version>9.12.1</lucene.version>
+    <elasticsearch.java.client.version>8.19.5</elasticsearch.java.client.version>

Review Comment:
   Good point. Lucene 10 requires java 21.
   But we are not actually using lucene core functionalities. The main reason we import it is that we need the analyzer package to allow configuration of custom analyzers.
   I can remove the imports and directly include in the module the required packages (like we do in oak-lucene).
   @thomasmueller any objection?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2469673342


##########
oak-search-elastic/pom.xml:
##########
@@ -33,8 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.java.client.version>8.18.2</elasticsearch.java.client.version>
-    <lucene.version>9.12.1</lucene.version>
+    <elasticsearch.java.client.version>8.19.5</elasticsearch.java.client.version>

Review Comment:
   AFAIU, Lucene 10 does not work on Java 11



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "thomasmueller (via GitHub)" <gi...@apache.org>.
thomasmueller commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2468830571


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -700,6 +700,8 @@ private ObjectBuilder<BoolQuery> inferenceConfigQuery(BoolQuery.Builder b, Strin
                         KnnQuery.Builder knnQueryBuilder = new KnnQuery.Builder();
                         knnQueryBuilder.field(InferenceConstants.VECTOR_SPACES + "." + inferenceModelConfigName + "." + InferenceConstants.VECTOR);
                         knnQueryBuilder.numCandidates(inferenceModelConfig.getNumCandidates());
+                        // see https://github.com/elastic/elasticsearch/pull/118774
+                        knnQueryBuilder.k(inferenceModelConfig.getNumCandidates());

Review Comment:
   Please add a description in the issue https://issues.apache.org/jira/browse/OAK-11998 and here.
   Even reading the linked page, I don't understand why the change is needed... Is it for backward compatibility?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "tihom88 (via GitHub)" <gi...@apache.org>.
tihom88 commented on code in PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597#discussion_r2468874988


##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/query/ElasticRequestHandler.java:
##########
@@ -700,6 +700,8 @@ private ObjectBuilder<BoolQuery> inferenceConfigQuery(BoolQuery.Builder b, Strin
                         KnnQuery.Builder knnQueryBuilder = new KnnQuery.Builder();
                         knnQueryBuilder.field(InferenceConstants.VECTOR_SPACES + "." + inferenceModelConfigName + "." + InferenceConstants.VECTOR);
                         knnQueryBuilder.numCandidates(inferenceModelConfig.getNumCandidates());
+                        // see https://github.com/elastic/elasticsearch/pull/118774
+                        knnQueryBuilder.k(inferenceModelConfig.getNumCandidates());

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OAK-11998: bump ES to 8.19.5, fix k for knn queries [jackrabbit-oak]

Posted by "fabriziofortino (via GitHub)" <gi...@apache.org>.
fabriziofortino merged PR #2597:
URL: https://github.com/apache/jackrabbit-oak/pull/2597


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org