[GitHub] [hive] pgaref commented on a change in pull request #1307: HIVE-23922: Improve code quality, UDFArgumentException.getMessage Method requires only two parameters

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #1307:
URL: https://github.com/apache/hive/pull/1307#discussion_r469396911



##########
File path: udf/src/java/org/apache/hadoop/hive/ql/exec/UDFArgumentException.java
##########
@@ -65,16 +65,13 @@ public UDFArgumentException(String message,
       Class<?> funcClass,
       List<TypeInfo> argTypeInfos,
       List<Method> methods) {
-    super(getMessage(message, funcClass, argTypeInfos, methods));
+    super(getMessage(message, methods));
     this.funcClass = funcClass;
     this.argTypeInfos = argTypeInfos;
     this.methods = methods;
   }
-  
-  private static String getMessage(String message, 
-      Class<?> funcClass,
-      List<TypeInfo> argTypeInfos,
-      List<Method> methods) {
+  //HIVE-23896 remove unnecessary parameter

Review comment:
       Could you please remove the comment and replace with a new line? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org