You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 10:15:29 UTC

Re: Review Request 68187: Always built shared protobuf libraries.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68187/#review213018
-----------------------------------------------------------



Patch looks great!

Reviews applied: [68187]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 3, 2018, 1:07 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68187/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2018, 1:07 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Always built shared protobuf libraries.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 8300088aaec5afd5ea92268757235d8561cda916 
> 
> 
> Diff: https://reviews.apache.org/r/68187/diff/1/
> 
> 
> Testing
> -------
> 
> `ninja tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>