[GitHub] [spark] uchiiii commented on a diff in pull request #36843: [SPARK-39446][MLLIB] Add relevance score for nDCG evaluation

[GitBox <gi...@apache.org>]

uchiiii commented on code in PR #36843:
URL: https://github.com/apache/spark/pull/36843#discussion_r896862293


##########
mllib/src/main/scala/org/apache/spark/mllib/evaluation/RankingMetrics.scala:
##########
@@ -35,8 +35,16 @@ import org.apache.spark.rdd.RDD
  * @param predictionAndLabels an RDD of (predicted ranking, ground truth set) pairs.
  */
 @Since("1.2.0")
-class RankingMetrics[T: ClassTag](predictionAndLabels: RDD[(Array[T], Array[T])])
-  extends Logging with Serializable {
+class RankingMetrics[T: ClassTag](
+    predictionAndLabels: RDD[(Array[T], Array[T], Array[(T, Double)])])

Review Comment:
   Thank you for your review.
   You definitely have a point. I changed from `(T, Double)` to `Double`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org