You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/02 01:10:08 UTC
[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #1056: feat: add mqtt-proxy plugin in ApisixRoute (#966)
tokers commented on code in PR #1056:
URL: https://github.com/apache/apisix-ingress-controller/pull/1056#discussion_r887414862
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -803,6 +803,22 @@ spec:
required:
- serviceName
- servicePort
+ plugins:
+ type: array
+ items:
+ type: object
+ properties:
+ name:
+ type: string
+ minLength: 1
+ enable:
+ type: boolean
+ config:
+ type: object
+ x-kubernetes-preserve-unknown-fields: true # we have to enable it since plugin config
Review Comment:
Incomplete comment?
##########
samples/deploy/crd/v1/ApisixRoute.yaml:
##########
@@ -803,6 +803,22 @@ spec:
required:
- serviceName
- servicePort
+ plugins:
+ type: array
+ items:
+ type: object
+ properties:
+ name:
+ type: string
+ minLength: 1
+ enable:
+ type: boolean
+ config:
+ type: object
+ x-kubernetes-preserve-unknown-fields: true # we have to enable it since plugin config
Review Comment:
Also, it looks like we don't add this field for the `plugins` of HTTP route.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org