Re: [PR] KAFKA-16190: Member should send full heartbeat when rejoining [kafka]

["phong260702 (via GitHub)" <gi...@apache.org>]

phong260702 commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1509566281


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -545,6 +545,15 @@ public ConsumerGroupHeartbeatRequestData buildRequestData() {
             // MemberEpoch - always sent
             data.setMemberEpoch(membershipManager.memberEpoch());
 
+            // Sent all fields if the member is joining/rejoining the group
+            if (membershipManager.state() == MemberState.JOINING) {

Review Comment:
   Thanks for the suggestion, I've changed it you take a look at it now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org