[GitHub] [airflow] ToxaZ commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'

[GitBox <gi...@apache.org>]

ToxaZ commented on a change in pull request #5913: [AIRFLOW-5073] Change SQLSensor to keep poking receving NULL, '0'
URL: https://github.com/apache/airflow/pull/5913#discussion_r346462895
 
 

 ##########
 File path: tests/sensors/test_sql_sensor.py
 ##########
 @@ -103,6 +103,18 @@ def test_sql_sensor_postgres_poke(self, mock_hook):
         mock_get_records.return_value = []
         self.assertFalse(t.poke(None))
 
+        mock_get_records.return_value = [['None']]
 
 Review comment:
   I guess `mock_get_records.return_value = []` would check exactly that issue. But I added another case to test for `[[None]]` explicitly

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services