You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/17 12:34:02 UTC
[GitHub] [ozone] sodonnel opened a new pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
sodonnel opened a new pull request #2546:
URL: https://github.com/apache/ozone/pull/2546
## What changes were proposed in this pull request?
TestPipelineClose.testPipelineCloseWithLogFailure is failing in a lot of PRs and is flaky. Disabling it to improve the build stability.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5624
## How was this patch tested?
Existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2546:
URL: https://github.com/apache/ozone/pull/2546#discussion_r690332110
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
##########
@@ -204,6 +205,7 @@ public void testPipelineCloseWithPipelineAction() throws Exception {
}
@Test
+ @Ignore
Review comment:
I suggest "linking" the issue as the reason for disabling it:
```suggestion
@Ignore("HDDS-5604")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a change in pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
sodonnel commented on a change in pull request #2546:
URL: https://github.com/apache/ozone/pull/2546#discussion_r690335987
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
##########
@@ -204,6 +205,7 @@ public void testPipelineCloseWithPipelineAction() throws Exception {
}
@Test
+ @Ignore
Review comment:
Thanks - I have made this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #2546:
URL: https://github.com/apache/ozone/pull/2546#issuecomment-900688254
I believe I have this fixed: https://github.com/apache/ozone/pull/2549
If that PR looks good we can merge that one instead of this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #2546:
URL: https://github.com/apache/ozone/pull/2546#issuecomment-900919454
I am going to go ahead and commit this, as it seems that even with #2549 the test fails sometimes. If we can get it stable, then we can remove the ignore here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
errose28 commented on pull request #2546:
URL: https://github.com/apache/ozone/pull/2546#issuecomment-900688254
I believe I have this fixed: https://github.com/apache/ozone/pull/2549
If that PR looks good we can merge that one instead of this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #2546:
URL: https://github.com/apache/ozone/pull/2546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
sodonnel merged pull request #2546:
URL: https://github.com/apache/ozone/pull/2546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on pull request #2546: HDDS-5624. Disable test TestPipelineClose.testPipelineCloseWithLogFailure
Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #2546:
URL: https://github.com/apache/ozone/pull/2546#issuecomment-900919454
I am going to go ahead and commit this, as it seems that even with #2549 the test fails sometimes. If we can get it stable, then we can remove the ignore here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org