You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/08/27 19:19:29 UTC

[GitHub] [fineract] Veeshal opened a new pull request #1844: NPE at AddressWritePlatformServiceImpl.addNewClientAddress().

Veeshal opened a new pull request #1844:
URL: https://github.com/apache/fineract/pull/1844


   
   Fixed NPE as addressTypeId was not validated.
   
   Also converted the static validation for address field configuration parameters to dynamic with exception to addressTypeId as its always mandatory during creation.
   
   There was spotlessJavaCheck at stream that I have ignored. Please let me know how to fix that so that the spotless is happy with my java. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola merged pull request #1844: NPE at AddressWritePlatformServiceImpl.addNewClientAddress() (FINERACT-1155)

Posted by GitBox <gi...@apache.org>.

ptuomola merged pull request #1844:
URL: https://github.com/apache/fineract/pull/1844


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #1844: NPE at AddressWritePlatformServiceImpl.addNewClientAddress() (FINERACT-1155)

Posted by GitBox <gi...@apache.org>.

awasum commented on pull request #1844:
URL: https://github.com/apache/fineract/pull/1844#issuecomment-919329973


   This is a proposed fix for issue: https://issues.apache.org/jira/browse/FINERACT-1155
   Thanks for contributing to Fineract @Veeshal 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1844: NPE at AddressWritePlatformServiceImpl.addNewClientAddress() (FINERACT-1155)

Posted by GitBox <gi...@apache.org>.

ptuomola commented on pull request #1844:
URL: https://github.com/apache/fineract/pull/1844#issuecomment-923959008


   Thanks for the contributing the fix - and taking the time to refactor the code! Great work. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org