You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/12/09 21:50:03 UTC
Review Request 54608: GEODE-2201 Make UITests a bit more resilient
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54608/
-----------------------------------------------------------
Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund.
Repository: geode
Description
-------
- Increase some timeouts
- Avoid StaleElementReferenceExceptions by retrying the element
retrieval.
This is an attempt to fix the continued failing of UITests in Concourse. I believe the issue is timing related and part of the fix may be to also run the UITests on a separate Concourse worker.
Diffs
-----
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java 91465f08f7a483cab0164f5d84dc8b0b8bdf780c
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java e273557430af57279c078438a37083b7bd1d14c9
geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseTestUtils.java c6ed3ff90f8250780beabe963ea02e6147ff4bc0
Diff: https://reviews.apache.org/r/54608/diff/
Testing
-------
Manual testing in Concourse environments
Thanks,
Jens Deppe
Re: Review Request 54608: GEODE-2201 Make UITests a bit more resilient
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54608/#review158725
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On Dec. 9, 2016, 9:50 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54608/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 9:50 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Increase some timeouts
> - Avoid StaleElementReferenceExceptions by retrying the element
> retrieval.
>
> This is an attempt to fix the continued failing of UITests in Concourse. I believe the issue is timing related and part of the fix may be to also run the UITests on a separate Concourse worker.
>
>
> Diffs
> -----
>
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java 91465f08f7a483cab0164f5d84dc8b0b8bdf780c
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java e273557430af57279c078438a37083b7bd1d14c9
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseTestUtils.java c6ed3ff90f8250780beabe963ea02e6147ff4bc0
>
> Diff: https://reviews.apache.org/r/54608/diff/
>
>
> Testing
> -------
>
> Manual testing in Concourse environments
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 54608: GEODE-2201 Make UITests a bit more resilient
Posted by Jared Stewart <js...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54608/#review158731
-----------------------------------------------------------
Ship it!
Ship It!
- Jared Stewart
On Dec. 9, 2016, 9:50 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54608/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 9:50 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Increase some timeouts
> - Avoid StaleElementReferenceExceptions by retrying the element
> retrieval.
>
> This is an attempt to fix the continued failing of UITests in Concourse. I believe the issue is timing related and part of the fix may be to also run the UITests on a separate Concourse worker.
>
>
> Diffs
> -----
>
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java 91465f08f7a483cab0164f5d84dc8b0b8bdf780c
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java e273557430af57279c078438a37083b7bd1d14c9
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseTestUtils.java c6ed3ff90f8250780beabe963ea02e6147ff4bc0
>
> Diff: https://reviews.apache.org/r/54608/diff/
>
>
> Testing
> -------
>
> Manual testing in Concourse environments
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 54608: GEODE-2201 Make UITests a bit more resilient
Posted by Kevin Duling <kd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54608/#review158730
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Duling
On Dec. 9, 2016, 1:50 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54608/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 1:50 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, and Kirk Lund.
>
>
> Repository: geode
>
>
> Description
> -------
>
> - Increase some timeouts
> - Avoid StaleElementReferenceExceptions by retrying the element
> retrieval.
>
> This is an attempt to fix the continued failing of UITests in Concourse. I believe the issue is timing related and part of the fix may be to also run the UITests on a separate Concourse worker.
>
>
> Diffs
> -----
>
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ScreenshotOnFailureRule.java 91465f08f7a483cab0164f5d84dc8b0b8bdf780c
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/WebDriverRule.java e273557430af57279c078438a37083b7bd1d14c9
> geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/ui/PulseTestUtils.java c6ed3ff90f8250780beabe963ea02e6147ff4bc0
>
> Diff: https://reviews.apache.org/r/54608/diff/
>
>
> Testing
> -------
>
> Manual testing in Concourse environments
>
>
> Thanks,
>
> Jens Deppe
>
>