[jira] Resolved: (WICKET-474) ComponentCreateTagTest#testRenderHomePage_6() fails with non-english environment

["Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Baptiste Quenot resolved WICKET-474.
-----------------------------------------

    Resolution: Fixed

Fixed by Matej, see http://svn.apache.org/viewvc?view=rev&rev=530589

> ComponentCreateTagTest#testRenderHomePage_6() fails with non-english environment
> --------------------------------------------------------------------------------
>
>                 Key: WICKET-474
>                 URL: https://issues.apache.org/jira/browse/WICKET-474
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3
>            Reporter: Jean-Baptiste Quenot
>             Fix For: 1.3
>
>
> {noformat}
> org.apache.wicket.util.convert.ConversionException: Cannot parse '4.1' using format java.text.DecimalFormat@674dc
> 	at org.apache.wicket.util.convert.converters.AbstractConverter.newConversionException(AbstractConverter.java:74)
> 	at org.apache.wicket.util.convert.converters.AbstractConverter.parse(AbstractConverter.java:54)
> 	at org.apache.wicket.util.convert.converters.AbstractNumberConverter.parse(AbstractNumberConverter.java:71)
> 	at org.apache.wicket.util.convert.converters.DoubleConverter.convertToObject(DoubleConverter.java:44)
> 	at org.apache.wicket.markup.resolver.AutoComponentResolver.invokeSetter(AutoComponentResolver.java:297)
> 	at org.apache.wicket.markup.resolver.AutoComponentResolver.createComponent(AutoComponentResolver.java:239)
> 	at org.apache.wicket.markup.resolver.AutoComponentResolver.resolve(AutoComponentResolver.java:95)
> 	at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1186)
> 	at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1329)
> 	at org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1264)
> 	at org.apache.wicket.Component.renderComponent(Component.java:1713)
> 	at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1274)
> 	at org.apache.wicket.Component.render(Component.java:1534)
> 	at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1159)
> 	at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1291)
> 	at org.apache.wicket.Page.onRender(Page.java:1261)
> 	at org.apache.wicket.Component.render(Component.java:1534)
> 	at org.apache.wicket.Page.renderPage(Page.java:826)
> 	at org.apache.wicket.request.target.component.BookmarkablePageRequestTarget.respond(BookmarkablePageRequestTarget.java:224)
> 	at org.apache.wicket.request.AbstractRequestCycleProcessor.respond(AbstractRequestCycleProcessor.java:103)
> 	at org.apache.wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:981)
> 	at org.apache.wicket.RequestCycle.step(RequestCycle.java:1048)
> 	at org.apache.wicket.RequestCycle.steps(RequestCycle.java:1127)
> 	at org.apache.wicket.RequestCycle.request(RequestCycle.java:535)
> 	at org.apache.wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:366)
> 	at org.apache.wicket.util.tester.BaseWicketTester.startPage(BaseWicketTester.java:237)
> 	at org.apache.wicket.WicketTestCase.executeTest(WicketTestCase.java:77)
> 	at org.apache.wicket.markup.ComponentCreateTagTest.testRenderHomePage_6(ComponentCreateTagTest.java:96)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:585)
> 	at junit.framework.TestCase.runTest(TestCase.java:154)
> 	at junit.framework.TestCase.runBare(TestCase.java:127)
> 	at junit.framework.TestResult$1.protect(TestResult.java:106)
> 	at junit.framework.TestResult.runProtected(TestResult.java:124)
> 	at junit.framework.TestResult.run(TestResult.java:109)
> 	at junit.framework.TestCase.run(TestCase.java:118)
> 	at junit.framework.TestSuite.runTest(TestSuite.java:208)
> 	at junit.framework.TestSuite.run(TestSuite.java:203)
> 	at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128)
> 	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
> 	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
> {noformat}
> If you look at testRenderHomePage_6() you notice this call:
> {code}
> tester.getWicketSession().setLocale(Locale.ENGLISH);
> {code}
> But unfortunately, a new session is created with the request's locale at the next line: executeTest, thus making the test fail on non-english environments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.