You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/02 15:41:06 UTC
[GitHub] [flink] sjwiesman opened a new pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
sjwiesman opened a new pull request #12810:
URL: https://github.com/apache/flink/pull/12810
## What is the purpose of the change
Add a local installation guide to "Try Flink"
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
Rendered:
<img width="786" alt="Screen Shot 2020-07-02 at 10 37 55 AM" src="https://user-images.githubusercontent.com/1891970/86379462-7dab3800-bc50-11ea-8d89-f95e687b9af8.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653081069
cc: @rmetzger @alpinegizmo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653120088
@alpinegizmo Its the same warning we use for the ops playground, I'll find the log message when merging. Thank you both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653121529
@alpinegizmo Actually, just to make it very clear, I will only print the warning on snapshot builds and hide the installation steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653090465
When I left my previous comment, I hadn't really digested the warning/explanation at the top of the page. Maybe that's sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo edited a comment on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
alpinegizmo edited a comment on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653086238
A couple of things to fix:
I don't think we publish snapshot builds, so the example with tar and cd is a bit off. (I realize this is probably a stable docs vs master docs issue, and I don't know of a good, easy solution.)
The output does not go to stdout. Maybe something like this:
```
{% highlight bash %}
$ tail log/flink-*-taskexecutor-*.out
(to,1)
(be,1)
(or,1)
(not,1)
(to,2)
(be,2)
...
{% endhighlight %}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653097476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30b55cd23e4904b4b737bc45055eddb3d3866ce0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4176",
"triggerID" : "30b55cd23e4904b4b737bc45055eddb3d3866ce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30b55cd23e4904b4b737bc45055eddb3d3866ce0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4176)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653097476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "30b55cd23e4904b4b737bc45055eddb3d3866ce0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "30b55cd23e4904b4b737bc45055eddb3d3866ce0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 30b55cd23e4904b4b737bc45055eddb3d3866ce0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653086238
A couple of things to fix:
I don't think we publish snapshot builds, so the example with tar and cd is a bit off. (I realize this is probably a stable docs vs master docs issue, and I don't know of a good, easy solution.)
The output does not go to stdout. Maybe something like this:
{% highlight bash %}
$ tail log/flink-*-taskexecutor-*.out
(to,1)
(be,1)
(or,1)
(not,1)
(to,2)
(be,2)
...
{% endhighlight %}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12810:
URL: https://github.com/apache/flink/pull/12810#issuecomment-653082325
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 30b55cd23e4904b4b737bc45055eddb3d3866ce0 (Thu Jul 02 15:43:53 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #12810: [FLINK-18472][docs] Local Installation Getting Started Guide
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #12810:
URL: https://github.com/apache/flink/pull/12810
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org