You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "mcmellawatt (GitHub)" <gi...@apache.org> on 2018/09/18 22:31:29 UTC
[GitHub] [geode] mcmellawatt opened pull request #2490: Adding
TESTING.md
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on pull request #2490: Adding
TESTING.md
Posted by "moleske (GitHub)" <gi...@apache.org>.
Just looking at the other checks on GitHub, do we not care about AcceptanceTest, StressNewTest, or UpgradeTest? StressNewTest has zero tests from a quick glance and the other two have corresponding `gradle` calls
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] moleske commented on pull request #2490: Adding
TESTING.md
Posted by "moleske (GitHub)" <gi...@apache.org>.
This example didn't work for me, but I'm feeling like maybe there's something I'm missing.
```
C:\Projects\geode [develop ≡]> ./gradlew.bat -PtestCategory=org.apache.geode.test.junit.categories.GfshTest distributedTest
FAILURE: Build failed with an exception.
* What went wrong:
Task '.apache.geode.test.junit.categories.GfshTest' not found in root project 'geode'.
* Try:
Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 7s
```
Maybe I was supposed to add the right project first?
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2490: Adding
TESTING.md
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
We decided to defer instructions for running tests in parallel to a later time, due to the complexity of enabling docker containers.
We tried to use this command, but it appears more parameters are required, specifically the image cannot be found.
`./gradlew -PparallelDunit distributedTest`
Error:
`com.github.dockerjava.api.exception.NotFoundException: {"message":"No such image: apachegeode/geode-build:latest"}`
If there is a simple way of addressing this, please let us know.
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt closed pull request #2490: Adding
TESTING.md
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pdxrunner commented on pull request #2490: Adding
TESTING.md
Posted by "pdxrunner (GitHub)" <gi...@apache.org>.
This needs to be formatted differently. The template and example commands display as a single run-on paragraph. Would be better to have each command displayed on a separate line. This is also true for the `Running Tests By Category` section
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2490: Adding
TESTING.md
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
We decided to defer instructions for running tests in parallel to a later time, due to the complexity of enabling docker containers.
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #2490:
Adding TESTING.md
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
No, its kind of a pain and you need a pretty beefy machine.
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2490: Adding
TESTING.md
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
I was able to reproduce on Windows and have found a working revised command. Thanks!
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2490: Adding
TESTING.md
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
Thanks Ken - will fix
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] mcmellawatt commented on pull request #2490: Adding
TESTING.md
Posted by "mcmellawatt (GitHub)" <gi...@apache.org>.
I think it makes sense to include acceptance and upgrade tests in the instructions. I'll add them. StressNewTest is really for CI - we "stress" brand new tests by running them many times to expose any unforeseen timing issues. I don't think it belongs in these instructions.
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #2490:
Adding TESTING.md
Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
You don't want to run integration or distributed tests in parallel without enabling the docker containers.
[ Full content available at: https://github.com/apache/geode/pull/2490 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org