You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/27 16:39:42 UTC
[GitHub] [spark] liancheng commented on a change in pull request #23788:
[SPARK-27176][SQL] Upgrade hadoop-3's built-in Hive maven dependencies to
2.3.4
liancheng commented on a change in pull request #23788: [SPARK-27176][SQL] Upgrade hadoop-3's built-in Hive maven dependencies to 2.3.4
URL: https://github.com/apache/spark/pull/23788#discussion_r269659870
##########
File path: pom.xml
##########
@@ -1414,6 +1414,23 @@
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
+ <!-- Hive 2.3.4 -->
+ <exclusion>
+ <groupId>org.eclipse.jetty.aggregate</groupId>
+ <artifactId>jetty-all</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.eclipse.jetty.orbit</groupId>
+ <artifactId>javax.servlet</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.github.joshelser</groupId>
+ <artifactId>dropwizard-metrics-hadoop-metrics2-reporter</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
Review comment:
Hey @wangyum, could you please add some detail comments here to explain why we want to exclude these dependencies? I can tell why we want to exclude them but it would be hard for other maintainers to figure out the intention in the future.
(In general, I'd say every single non-trivial dependency treatment, like exclusion and shading, should require a detail comment to explain the intention. Unfortunately, we are not doing this historically.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org