You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/08 22:39:45 UTC
[GitHub] [superset] ktmud opened a new issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
ktmud opened a new issue #12364:
URL: https://github.com/apache/superset/issues/12364
#### Screenshots
#### How to reproduce the bug
1. Add a at least two metrics
2. Click to open the popover of the second metric
3. Drag & Drop to change order
4. Save the popover.
5. It should have updated the original metric but it updates the other metric at the original position instead.
6. Then if change the other metric, both metrics are updated.
### Environment
Latest master
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-759701793
Sounds right.major refactoring work for control fields is gonna happen soon.We will address all related known issue together. But feel free to add p1 label if you consider this particular one as 1.0 release blocker @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-766616418
This behavior only happens when you have two same metrics. which means... it has been resolved by https://github.com/apache/superset/pull/12657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-767369417
https://user-images.githubusercontent.com/335541/105816164-ce75db80-5f68-11eb-819c-c1fa9d1b4618.mp4
This bug is still reproducible. As noted in the original issue description, it happens when you do Drag & Drop while the popover is open.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-767369417
https://user-images.githubusercontent.com/335541/105816164-ce75db80-5f68-11eb-819c-c1fa9d1b4618.mp4
This bug is still reproducible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-766616418
This behavior only happens when you have two same metrics. which means... it has been resolved by https://github.com/apache/superset/pull/12657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-759696511
@junlincc I don't think this is a cosmetic issue. It's a functionally incorrect behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #12364: [Explore] Metric/Filter Popover should always corresponds to the actual metric/filter item
Posted by GitBox <gi...@apache.org>.
geido commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-846995754
@kgabryje would you mind getting this under your wing? It looks like you have worked on this functionality heavily and you should have more context than I do. I am struggling to find the root cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12364:
URL: https://github.com/apache/superset/issues/12364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12364: [Explore] Drag & Drop Adhoc Metric while the Popover is open messes things up
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12364:
URL: https://github.com/apache/superset/issues/12364
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #12364: [Explore] Metric/Filter Popover should always corresponds to the actual metric/filter item
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #12364:
URL: https://github.com/apache/superset/issues/12364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #12364: [Explore] Metric/Filter Popover should always corresponds to the actual metric/filter item
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-818258091
Another symptom of the same indexing/selected item IDing issue: if you delete one of the metric/adhoc filter, the popover messes up for all other items after the deleted one.
https://user-images.githubusercontent.com/335541/114465478-079f0e80-9b9c-11eb-9c1c-a730f961f2ac.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #12364: [Explore] Metric/Filter Popover should always corresponds to the actual metric/filter item
Posted by GitBox <gi...@apache.org>.
geido commented on issue #12364:
URL: https://github.com/apache/superset/issues/12364#issuecomment-840483769
I'll have a look at this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org