You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/08 13:03:33 UTC
[GitHub] [apisix] slene opened a new pull request #4564: fix: ctx.var.cookie_* cookie not found log
slene opened a new pull request #4564:
URL: https://github.com/apache/apisix/pull/4564
### What this PR does / why we need it:
fix: #4516
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4564:
URL: https://github.com/apache/apisix/pull/4564#discussion_r666647180
##########
File path: t/core/ctx.t
##########
@@ -83,8 +83,8 @@ arg_a: aaa
GET /t?a=aaa
--- response_body
cookie_host: nil
---- error_log
-failed to fetch cookie value by key: cookie_host error: no cookie found in the current request
+--- no_error_log
+[error]
Review comment:
**You don't actually check it.** The original log message is a warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] slene commented on pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
slene commented on pull request #4564:
URL: https://github.com/apache/apisix/pull/4564#issuecomment-876428281
@spacewander review plz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4564:
URL: https://github.com/apache/apisix/pull/4564#discussion_r666605335
##########
File path: t/core/ctx.t
##########
@@ -83,8 +83,8 @@ arg_a: aaa
GET /t?a=aaa
--- response_body
cookie_host: nil
---- error_log
-failed to fetch cookie value by key: cookie_host error: no cookie found in the current request
+--- no_error_log
+[error]
Review comment:
```suggestion
failed to fetch cookie value by key
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] slene commented on a change in pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
slene commented on a change in pull request #4564:
URL: https://github.com/apache/apisix/pull/4564#discussion_r666644087
##########
File path: t/core/ctx.t
##########
@@ -83,8 +83,8 @@ arg_a: aaa
GET /t?a=aaa
--- response_body
cookie_host: nil
---- error_log
-failed to fetch cookie value by key: cookie_host error: no cookie found in the current request
+--- no_error_log
+[error]
Review comment:
Why ? Ci is passed and no error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] slene commented on a change in pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
slene commented on a change in pull request #4564:
URL: https://github.com/apache/apisix/pull/4564#discussion_r666622257
##########
File path: t/core/ctx.t
##########
@@ -83,8 +83,8 @@ arg_a: aaa
GET /t?a=aaa
--- response_body
cookie_host: nil
---- error_log
-failed to fetch cookie value by key: cookie_host error: no cookie found in the current request
+--- no_error_log
+[error]
Review comment:
❓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4564:
URL: https://github.com/apache/apisix/pull/4564#discussion_r666622600
##########
File path: t/core/ctx.t
##########
@@ -83,8 +83,8 @@ arg_a: aaa
GET /t?a=aaa
--- response_body
cookie_host: nil
---- error_log
-failed to fetch cookie value by key: cookie_host error: no cookie found in the current request
+--- no_error_log
+[error]
Review comment:
Change `[error]` to `failed to fetch cookie value by key`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #4564: fix: ctx.var.cookie_* cookie not found log
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #4564:
URL: https://github.com/apache/apisix/pull/4564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org