You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "ashishvijaywargiya (via GitHub)" <gi...@apache.org> on 2026/08/22 11:36:58 UTC
[PR] Remove per-component test-run REST wrappers, superseded by the generic testtools endpoint [ofbiz-plugins]
ashishvijaywargiya opened a new pull request, #374:
URL: https://github.com/apache/ofbiz-plugins/pull/374
Title: Remove per-component test-run REST wrappers, superseded by the generic testtools endpoint
Deletes the per-component test-run REST wrapper pattern from example, ecommerce, assetmaint,
lucene, and scrum:
- the groovy wrapper class in each component (e.g. ExampleTestRunServices.groovy)
- the two duplicated <service> definitions each wrapper needed, in each component's
servicedef/services.xml
- each component's own test-run *.rest.xml (for example, this is the TestRunResource block
removed from its shared rest.xml, since that file also carries example's own business-service
REST resource; for the other four it is the entire file, since they had nothing else in it)
ecommerce's servicedef/services.xml and its ofbiz-component.xml service-resource entry are
removed entirely - that file existed solely to declare the two now-deleted services.
Why
Superseded by a new, generic, framework-owned REST endpoint added in the companion
ofbiz-framework pull request, which takes componentName as a URL path parameter and needs no
per-component files at all. All five components' tests remain reachable, now via
POST /rest/testtools/testruns/{componentName}
GET /rest/testtools/testruns/{runId}
instead of each component's own separately-branded URL.
No changes to any component's actual test suites, Jupiter test classes, or testdef files - this
is REST/service wiring only.
Testing
- gradlew classes testClasses passes after each component's change.
- Full sweep against a running server: all five old branded URLs (example-rest, ecommerce-rest,
assetmaint-rest, lucene-rest, scrum-rest) confirmed gone (404); all five components' real test
suites confirmed passing end-to-end through the new generic endpoint.
- Full testIntegration run across the whole codebase: 658/658 tests passing, zero regressions.
Dependency on the companion pull request
This should merge together with, or before, the companion ofbiz-framework pull request. This PR
removes the last callers of TestRunServices.runScopedTestSuite/getScopedTestRunStatus, which the
framework PR deletes. Merging the framework PR first while these wrapper scripts are still
present would leave them calling methods that no longer exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove per-component test-run REST wrappers, superseded by the generic testtools endpoint [ofbiz-plugins]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #374:
URL: https://github.com/apache/ofbiz-plugins/pull/374#issuecomment-5380005826
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=374) **Quality Gate failed**
Failed conditions
 [28.4% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=374&metric=new_duplicated_lines_density&view=list) (required ≤ 3%)
<!-- sqra:qg_revision=3adc065adcc36a0f4141c780256c69f609cf95a83373a78ac4ce0d81b4861281 -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=374)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove per-component test-run REST wrappers, superseded by the generic testtools endpoint [ofbiz-plugins]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #374:
URL: https://github.com/apache/ofbiz-plugins/pull/374#issuecomment-5380085703
## [](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=374) **Quality Gate passed**
Issues
 [12 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=374&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=374&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=374&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=374&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=374&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=374)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove per-component test-run REST wrappers, superseded by the generic testtools endpoint [ofbiz-plugins]
Posted by "ashishvijaywargiya (via GitHub)" <gi...@apache.org>.
ashishvijaywargiya merged PR #374:
URL: https://github.com/apache/ofbiz-plugins/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org