You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "1330571 (via GitHub)" <gi...@apache.org> on 2023/02/26 13:40:41 UTC
[GitHub] [doris] 1330571 opened a new pull request, #17148: [feature](cooldown) Forbid storage policy for MoW tables
1330571 opened a new pull request, #17148:
URL: https://github.com/apache/doris/pull/17148
# Proposed changes
Issue Number: close #17065
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [x] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #17148:
URL: https://github.com/apache/doris/pull/17148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445703086
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445399093
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445721935
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445365006
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445383286
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445788299
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445663290
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #17148:
URL: https://github.com/apache/doris/pull/17148#discussion_r1118186121
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1969,6 +1976,12 @@ public void updatePartitionsProperties(Database db, String tableName, List<Strin
}
}
String storagePolicy = properties.get(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY);
+ boolean enableUniqueKeyMergeOnWrite = olapTable.getEnableUniqueKeyMergeOnWrite();
+ if (enableUniqueKeyMergeOnWrite && !storagePolicy.equals("")) {
Review Comment:
```suggestion
if (enableUniqueKeyMergeOnWrite && !Strings.isNullOrEmpty(storagePolicy)) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1934,6 +1936,11 @@ public void updateTableProperties(Database db, String tableName, Map<String, Str
}
}
String storagePolicy = properties.get(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY);
+ if (enableUniqueKeyMergeOnWrite && !storagePolicy.equals("")) {
Review Comment:
```suggestion
if (enableUniqueKeyMergeOnWrite && !Strings.isNullOrEmpty(storagePolicy)) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java:
##########
@@ -101,7 +101,14 @@ public void analyze(Analyzer analyzer) throws AnalysisException {
throw new AnalysisException("Alter tablet type not supported");
} else if (properties.containsKey(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY)) {
this.needTableStable = false;
- setStoragePolicy(properties.getOrDefault(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY, ""));
+ String storagePolicy = properties.getOrDefault(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY, "");
+ if (!storagePolicy.equals("")
Review Comment:
```suggestion
if (!Strings.isNullOrEmpty(storagePolicy)
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2013,6 +2013,11 @@ private void createOlapTable(Database db, CreateTableStmt stmt) throws UserExcep
// set storage policy
String storagePolicy = PropertyAnalyzer.analyzeStoragePolicy(properties);
Env.getCurrentEnv().getPolicyMgr().checkStoragePolicyExist(storagePolicy);
+ if (olapTable.getEnableUniqueKeyMergeOnWrite() && !storagePolicy.equals("")) {
Review Comment:
```suggestion
if (olapTable.getEnableUniqueKeyMergeOnWrite() && !Strings.isNullOrEmpty(storagePolicy)) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2231,6 +2236,11 @@ private void createOlapTable(Database db, CreateTableStmt stmt) throws UserExcep
DistributionInfo partitionDistributionInfo = distributionDesc.toDistributionInfo(baseSchema);
// use partition storage policy if it exist.
String partionStoragePolicy = partitionInfo.getStoragePolicy(entry.getValue());
+ if (olapTable.getEnableUniqueKeyMergeOnWrite() && !partionStoragePolicy.equals("")) {
Review Comment:
```suggestion
if (olapTable.getEnableUniqueKeyMergeOnWrite() && !Strings.isNullOrEmpty(partitionStoragePolicy)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17148: [feature](cooldown) Forbid storage policy for MoW tables
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17148:
URL: https://github.com/apache/doris/pull/17148#issuecomment-1445788262
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org