You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by timothyjward <gi...@git.apache.org> on 2015/12/08 16:04:13 UTC

[GitHub] zookeeper pull request: Use fake host names to avoid test failures

GitHub user timothyjward opened a pull request:

    https://github.com/apache/zookeeper/pull/48

    Use fake host names to avoid test failures

    Some of the ZooKeeper tests use "fake" hostnames to trigger host resolution failures. The problem with this is that it uses valid hostnames which are sometimes configured in VMs. 
    
    At the moment I am unable to build cleanly because I get test failures on the two test methods that do this. The tests work equally well if syntactically invalid hostnames are used, and the test cases become more portable at the same time.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/timothyjward/zookeeper hostname-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/48.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #48
    
----
commit ac1919483026d02febf271041df54a4685c38489
Author: Tim Ward <ti...@apache.org>
Date:   2015-12-02T17:17:52Z

    Use fake host names to avoid test failures

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zookeeper pull request: Use fake host names to avoid test failures

Posted by timothyjward <gi...@git.apache.org>.
Github user timothyjward closed the pull request at:

    https://github.com/apache/zookeeper/pull/48


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---