You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "yifan-c (via GitHub)" <gi...@apache.org> on 2025/02/16 03:55:58 UTC
[PR] CASSSIDECAR-213: Release resources in unit tests [cassandra-sidecar]
yifan-c opened a new pull request, #195:
URL: https://github.com/apache/cassandra-sidecar/pull/195
Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-213: Release resources in unit tests [cassandra-sidecar]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c merged PR #195:
URL: https://github.com/apache/cassandra-sidecar/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-213: Release resources in unit tests [cassandra-sidecar]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #195:
URL: https://github.com/apache/cassandra-sidecar/pull/195#discussion_r1958861407
##########
server/src/test/resources/config/sidecar_cdc.yaml:
##########
@@ -59,7 +59,7 @@ sidecar:
cdc:
segment_hardlink_cache_expiry: 1m # 1 minute
jmx:
- max_retries: 42
+ max_retries: 1
Review Comment:
For reviewers, the 42 retries is just too much for testing. The retry blocks the closure of server, leading to the test being stuck for 30 minutes and killed by test runner.
Changing it to 1 does not alter the tests, but allows test completion way faster (like, in milliseconds).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSSIDECAR-213: Release resources in unit tests [cassandra-sidecar]
Posted by "yifan-c (via GitHub)" <gi...@apache.org>.
yifan-c commented on code in PR #195:
URL: https://github.com/apache/cassandra-sidecar/pull/195#discussion_r1958861910
##########
server/src/test/java/org/apache/cassandra/sidecar/config/SidecarConfigurationTest.java:
##########
@@ -112,7 +112,7 @@ void testReadingJmxConfiguration() throws IOException
SidecarConfiguration config = SidecarConfigurationImpl.readYamlConfiguration(yamlPath);
assertThat(config.serviceConfiguration().jmxConfiguration()).isNotNull();
JmxConfiguration jmxConfiguration = config.serviceConfiguration().jmxConfiguration();
- assertThat(jmxConfiguration.maxRetries()).isEqualTo(42);
+ assertThat(jmxConfiguration.maxRetries()).isEqualTo(1);
Review Comment:
We all like the ultimate answer, but since it has been modified in the ymls, update the test assertion accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org