You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Malarg (via GitHub)" <gi...@apache.org> on 2023/05/30 06:13:07 UTC
[GitHub] [beam] Malarg opened a new pull request, #26932: Issue26858 tob tests examples
Malarg opened a new pull request, #26932:
URL: https://github.com/apache/beam/pull/26932
Handled failed to load example error
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #26932: Issue26858 tob tests examples
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1576550881
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26932: Issue26858 tob tests examples
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1567847935
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] nausharipov commented on a diff in pull request #26932: Issue26858 tob tests examples
Posted by "nausharipov (via GitHub)" <gi...@apache.org>.
nausharipov commented on code in PR #26932:
URL: https://github.com/apache/beam/pull/26932#discussion_r1214171925
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -147,7 +154,12 @@ class ExamplesLoader {
Example example;
try {
example = await loader.future;
- } on Exception {
+ } on MultipleExceptions catch (ex) {
+ example = Example.empty(loader.sdk ?? Sdk.java);
+ _handleLoadException(loader, ex);
+ } on Exception catch (ex) {
+ example = Example.empty(loader.sdk ?? Sdk.java);
+ _handleLoadException(loader, ex);
Review Comment:
Is this relevant now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #26932: Issue26858 tob tests examples
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #26932:
URL: https://github.com/apache/beam/pull/26932#discussion_r1209767309
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -70,6 +76,7 @@ class ExamplesLoader {
Future<void> load(ExamplesLoadingDescriptor descriptor) async {
_descriptor = descriptor;
final loaders = descriptor.descriptors.map(_createLoader).whereNotNull();
+ print('Loaders: ' + loaders.map((e) => e.descriptor.token).join(', '));
Review Comment:
Delete.
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -43,6 +47,8 @@ class ExamplesLoader {
PlaygroundController? _playgroundController;
ExamplesLoadingDescriptor? _descriptor;
+ static List failedToLoadExamples = List<String>.empty(growable: true);
Review Comment:
```suggestion
static final failedToLoadExamples = <String>[];
```
##########
learning/tour-of-beam/frontend/integration_test/tour_page_test.dart:
##########
@@ -1,3 +1,5 @@
+// ignore_for_file: avoid_print
Review Comment:
After license.
##########
playground/frontend/lib/main.dart:
##########
@@ -31,6 +31,7 @@ import 'l10n/l10n.dart';
import 'locator.dart';
import 'playground_app.dart';
+//temp comment
Review Comment:
Delete.
##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -147,7 +154,12 @@ class ExamplesLoader {
Example example;
try {
example = await loader.future;
- } on Exception {
+ } on MultipleExceptions catch (ex) {
+ example = Example.empty(loader.sdk ?? Sdk.java);
+ _handleLoadException(loader, ex);
+ } on Exception catch (ex) {
+ example = Example.empty(loader.sdk ?? Sdk.java);
+ _handleLoadException(loader, ex);
Review Comment:
Explain why we do not throw in one of the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #26932: Issue26858 tob tests examples
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1579990417
The Playground tests are broken after the MinimalWordCount update. I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #26932: Issue26858 tob tests examples
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #26932:
URL: https://github.com/apache/beam/pull/26932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26932: Issue26858 tob tests examples
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1573632082
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #26932: Issue26858 tob tests examples
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1583158744
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26932: Issue26858 tob tests examples
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1574327710
waiting on author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26932: Issue26858 tob tests examples
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26932:
URL: https://github.com/apache/beam/pull/26932#issuecomment-1576552233
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org