You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by Thilo Goetz <tw...@gmx.de> on 2007/08/23 16:59:31 UTC
Java 5 [was: Re: svn commit: r569003 - in /incubator/uima/uimaj/trunk/uimaj-core/src:
main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java
test/java/org/apache/uima/resource/metadata/impl/MetaDataObject_implTest.java]
schor@apache.org wrote:
> Author: schor
> Date: Thu Aug 23 07:11:20 2007
> New Revision: 569003
>
> URL: http://svn.apache.org/viewvc?rev=569003&view=rev
> Log:
> [UIMA-534] fix equals test for Maps, also make Array tests cover
> more cases, including arrays of arrays
>
> Added:
> incubator/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/resource/metadata/impl/MetaDataObject_implTest.java
> Modified:
> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java
>
> Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java
> URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java?rev=569003&r1=569002&r2=569003&view=diff
> ==============================================================================
> --- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java (original)
> +++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java Thu Aug 23 07:11:20 2007
[...]
> + if (val1 instanceof Object[]) return Arrays.deepEquals((Object[])val1, (Object[])val2);
Marshall, thanks for forcing the Java 5 issue ;-)
Seriously, I think we've only heard positive opinions
about moving to Java 5. Our users haven't complained
either, to the contrary. If anybody has strong feelings
about being 1.4 compatible, speak up now or forever
hold your peace :-)
--Thilo
Re: Java 5 [was: Re: svn commit: r569003 - in /incubator/uima/uimaj/trunk/uimaj-core/src:
main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java
test/java/org/apache/uima/resource/metadata/impl/MetaDataObject_implTest.java]
Posted by Marshall Schor <ms...@schor.com>.
Oops, now I know why "deepEquals()" wasn't familiar... I didn't realize
it was a Java 5 thing...
This one's not critical - so I would lean toward putting it back to just
plain equals.
Opinions? -Marshall
Thilo Goetz wrote:
> schor@apache.org wrote:
>
>> Author: schor
>> Date: Thu Aug 23 07:11:20 2007
>> New Revision: 569003
>>
>> URL: http://svn.apache.org/viewvc?rev=569003&view=rev
>> Log:
>> [UIMA-534] fix equals test for Maps, also make Array tests cover
>> more cases, including arrays of arrays
>>
>> Added:
>> incubator/uima/uimaj/trunk/uimaj-core/src/test/java/org/apache/uima/resource/metadata/impl/MetaDataObject_implTest.java
>> Modified:
>> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java
>>
>> Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java
>> URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java?rev=569003&r1=569002&r2=569003&view=diff
>> ==============================================================================
>> --- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java (original)
>> +++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/resource/metadata/impl/MetaDataObject_impl.java Thu Aug 23 07:11:20 2007
>>
> [...]
>
>
>> + if (val1 instanceof Object[]) return Arrays.deepEquals((Object[])val1, (Object[])val2);
>>
>
>
> Marshall, thanks for forcing the Java 5 issue ;-)
>
> Seriously, I think we've only heard positive opinions
> about moving to Java 5. Our users haven't complained
> either, to the contrary. If anybody has strong feelings
> about being 1.4 compatible, speak up now or forever
> hold your peace :-)
>
> --Thilo
>
>
>