[GitHub] [incubator-opendal] morristai commented on issue #743: Add Throttle Support

["morristai (via GitHub)" <gi...@apache.org>]

morristai commented on issue #743:
URL: https://github.com/apache/incubator-opendal/issues/743#issuecomment-1577896951

   > Thanks a lot for the research!
   > 
   > > * As for Leaky Bucket, this crate offers a similar algorithm([Generic Cell Rate Algorithm (GCRA)](https://en.wikipedia.org/wiki/Generic_cell_rate_algorithm)) to Leaky Bucket, but has a few advantages over most Leaky Bucket implementations: [governor/README.md at master · antifuchs/governor · GitHub](https://github.com/antifuchs/governor/blob/master/governor/README.md)
   > 
   > `governor` LGTM!
   
   Sounds good. The governor supports two types of limiters: "direct" and "keyed".
   
   - Direct rate limiters maintain a single state, such as the rate of outgoing email conversations.
   - Keyed rate limiters, on the other hand, maintain a separate rate limiting state for each key. For example, they can be used to regulate the flow of API requests made by each customer.
   
   Currently, I am unsure how to implement the Keyed Limiter as it requires interaction with the throttle layer state after building the Operator. Should I first try implementing the Direct Limiter, as all operations under an operator share an Atomic Limiter?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org