You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (JIRA)" <ji...@apache.org> on 2010/10/10 08:52:30 UTC

[jira] Issue Comment Edited: (SOLR-2002) improve build/tests

    [ https://issues.apache.org/jira/browse/SOLR-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919577#action_12919577 ] 

Steven Rowe edited comment on SOLR-2002 at 10/10/10 2:51 AM:
-------------------------------------------------------------

Attached patch syncs up to current trunk, and includes dataimporthandler-extras in the build, by moving it to its own directory under {{solr/contrib/}}.  All tests run and pass.

Run the following script before applying the patch, which was created using {{svn --no-diff-deleted diff}}:

{code}
mkdir -p solr/contrib/dataimporthandler-extras/src
svn move solr/contrib/dataimporthandler/src/extras/main/ solr/contrib/dataimporthandler-extras/src/main
svn move solr/contrib/dataimporthandler/src/extras/test solr/contrib/dataimporthandler-extras/src/test
{code}

{{solr/contrib/dataimporthandler-extras/build.xml}} is a lot more complicated than the other Solr contrib build files, because it has non-standard dependencies at compile and test time.  I think this can be cleaned up and consolidated, e.g. with some of the stuff in {{solr/build.xml}} - the attached patch is just what it took to get it to work.

      was (Author: steve_rowe):
    Attached patch syncs up to current trunk, and includes dataimporthandler-extras in the build, by moving it to its own directory under {{solr/contrib/}}.  All tests run and pass.

Run the following script before applying the patch, which was created using {{svn --no-diff-deleted diff}}:

{code}
svn move solr/contrib/dataimporthandler/src/extras/main/ solr/contrib/dataimporthandler-extras/src/main
mkdir -p solr/contrib/dataimporthandler-extras/src
svn move solr/contrib/dataimporthandler/src/extras/main/ solr/contrib/dataimporthandler-extras/src/main
svn move solr/contrib/dataimporthandler/src/extras/test solr/contrib/dataimporthandler-extras/src/test
{code}

{{solr/contrib/dataimporthandler-extras/build.xml}} is a lot more complicated than the other Solr contrib build files, because it has non-standard dependencies at compile and test time.  I think this can be cleaned up and consolidated, e.g. with some of the stuff in {{solr/build.xml}} - the attached patch is just what it took to get it to work.
  
> improve build/tests
> -------------------
>
>                 Key: SOLR-2002
>                 URL: https://issues.apache.org/jira/browse/SOLR-2002
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2002.patch, SOLR-2002_core_contrib.patch, SOLR-2002_localization.patch, SOLR-2002_lucenetestcase.patch, SOLR-2002_merged.patch, SOLR-2002_merged.patch, SOLR-2002_replication.patch, SOLR-2002_testiter.patch, SOLR-2002_testmethod.patch, SOLR-2002_timeout.patch, SOLR-2002setupteardown.patch
>
>
> we are working on improving some functionality in lucene's build/tests, it would be good to improve the solr side to take advantage of it.
> currently its only sorta-kinda integrated and a bit messy.
> i'd like to do some incremental improvements piece-by-piece on this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org