You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Venkatesan Ramachandran <me...@gmail.com> on 2015/12/01 22:59:05 UTC
Review Request 40842: FALCON-1645 : Ability to export to database -
Entity Definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40842/
-----------------------------------------------------------
Review request for Falcon.
Repository: falcon-git
Description
-------
Feed entity to have export capability.
Validations to be handled in the code are:
1. Import can only be tied to source cluster
2. Export can be on source and target cluster
3. Import and Export of the feed should not go to the same combination of Datasource and Table
Diffs
-----
client/src/main/resources/feed-0.1.xsd 2974dd6
Diff: https://reviews.apache.org/r/40842/diff/
Testing
-------
Thanks,
Venkatesan Ramachandran
Re: Review Request 40842: FALCON-1645 : Ability to export to database
- Entity Definition
Posted by Venkatesan Ramachandran <me...@gmail.com>.
> On Dec. 1, 2015, 10:19 p.m., Balu Vellanki wrote:
> > client/src/main/resources/feed-0.1.xsd, line 460
> > <https://reviews.apache.org/r/40842/diff/1/?file=1149850#file1149850line460>
> >
> > The name "source" can confuse users as it is actually the target to which feed is being exported to. Isnt it?
Good point.
- Venkatesan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40842/#review108570
-----------------------------------------------------------
On Dec. 1, 2015, 9:59 p.m., Venkatesan Ramachandran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40842/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 9:59 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Feed entity to have export capability.
> Validations to be handled in the code are:
> 1. Import can only be tied to source cluster
> 2. Export can be on source and target cluster
> 3. Import and Export of the feed should not go to the same combination of Datasource and Table
>
>
> Diffs
> -----
>
> client/src/main/resources/feed-0.1.xsd 2974dd6
>
> Diff: https://reviews.apache.org/r/40842/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkatesan Ramachandran
>
>
Re: Review Request 40842: FALCON-1645 : Ability to export to database
- Entity Definition
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40842/#review108570
-----------------------------------------------------------
client/src/main/resources/feed-0.1.xsd (line 460)
<https://reviews.apache.org/r/40842/#comment168022>
The name "source" can confuse users as it is actually the target to which feed is being exported to. Isnt it?
- Balu Vellanki
On Dec. 1, 2015, 9:59 p.m., Venkatesan Ramachandran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40842/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 9:59 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Feed entity to have export capability.
> Validations to be handled in the code are:
> 1. Import can only be tied to source cluster
> 2. Export can be on source and target cluster
> 3. Import and Export of the feed should not go to the same combination of Datasource and Table
>
>
> Diffs
> -----
>
> client/src/main/resources/feed-0.1.xsd 2974dd6
>
> Diff: https://reviews.apache.org/r/40842/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkatesan Ramachandran
>
>
Re: Review Request 40842: FALCON-1645 : Ability to export to database
- Entity Definition
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40842/#review108571
-----------------------------------------------------------
Apart from the single comment, the XSD looks good to me.
- Balu Vellanki
On Dec. 1, 2015, 9:59 p.m., Venkatesan Ramachandran wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40842/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 9:59 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Feed entity to have export capability.
> Validations to be handled in the code are:
> 1. Import can only be tied to source cluster
> 2. Export can be on source and target cluster
> 3. Import and Export of the feed should not go to the same combination of Datasource and Table
>
>
> Diffs
> -----
>
> client/src/main/resources/feed-0.1.xsd 2974dd6
>
> Diff: https://reviews.apache.org/r/40842/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkatesan Ramachandran
>
>