[GitHub] [arrow] thisisnic edited a comment on pull request #10598: ARROW-13054: [C++] Add TemporalOptions

[GitBox <gi...@apache.org>]

thisisnic edited a comment on pull request #10598:
URL: https://github.com/apache/arrow/pull/10598#issuecomment-868358466


   > Is this missing an option we will need in the near future? Should we remove something.
   > @jorisvandenbossche @thisisnic
   
   Thanks for this! I've taken a look at the `lubridate` package in R, and in terms of options that are implemented in `lubridate` (specifically for functions which are used for extracting components of date-time objects as I am assuming that is the scope of this - correct me if I'm wrong though!) but not here, there is:
   
   * `fiscal_start` - this is an argument to `quarter` which indicates the starting month of a fiscal year - I think this would be useful to implement
   
   * `with_year` - an argument to `quarter` which defines whether the returned value is just the quarter or the quarter *and* the year - I'm not sure about this one - it feels like it's doing something that can be achieved by combining the year/quarter returned values but if it's  widely used in other implementations, perhaps we should consider it?
   
   * `label` - an argument to `month` and `wday` (aka `day_of_week` in Arrow) which defines whether the returned value is an integer or character representation of the month - as discussed on https://issues.apache.org/jira/browse/ARROW-13133, this can be achieved via a separate `strftime` kernel
   
   * `abbr` - works with `label` and determines whether the label is abbreviated - I think this belongs to the `strftime` kernel
   
   * `locale` - locale to use for month/week day names if `label` is set to `TRUE`- I think this belongs to the `strftime` kernel
   
   So, yeah, I'm thinking `fiscal_start` is the only other accessor option that would definitely be good to add, but it'd be good to get input from @nealrichardson on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org