You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/08/20 04:27:41 UTC

[Bug 120619] New: [From Symphony]it's slow to open the simple xslx file

https://issues.apache.org/ooo/show_bug.cgi?id=120619

          Priority: P3
            Bug ID: 120619
          Assignee: ooo-issues@incubator.apache.org
           Summary: [From Symphony]it's slow to open the simple xslx file
          Severity: normal
        Issue Type: DEFECT
    Classification: Application
                OS: Windows XP
          Reporter: companycy@gmail.com
          Hardware: All
            Status: UNCONFIRMED
           Version: AOO350-dev
         Component: open-import
           Product: spreadsheet

Created attachment 79003
  --> https://issues.apache.org/ooo/attachment.cgi?id=79003&action=edit
Sample xslx takes long time to open

It takes long time to open simple xslx file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120619] [From Symphony]it's slow to open the simple xslx file

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120619

--- Comment #1 from bjcheny <co...@gmail.com> ---
It takes almost 300 sec to open sample file on my pc. 
I am working on patch for this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120619] [From Symphony]it's slow to open the simple xslx file

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120619

Terry Yang <po...@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |polo8495@hotmail.com
     Ever confirmed|0                           |1

--- Comment #4 from Terry Yang <po...@hotmail.com> ---
Confirm this bug at my side, change bug to confirm status

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120619] [From Symphony]it's slow to open the simple xslx file

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120619

bjcheny <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79126|0                           |1
        is obsolete|                            |
  Attachment #79126|review?                     |
              Flags|                            |

--- Comment #6 from bjcheny <co...@gmail.com> ---
Comment on attachment 79126
  --> https://issues.apache.org/ooo/attachment.cgi?id=79126
patch for performance of importing cell style in xslx

Mark this patch duplicated with bug 120824

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120619] [From Symphony]it's slow to open the simple xslx file

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120619

bjcheny <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79163|                            |review?
              Flags|                            |

--- Comment #3 from bjcheny <co...@gmail.com> ---
Created attachment 79163
  --> https://issues.apache.org/ooo/attachment.cgi?id=79163&action=edit
patch for performance of importing cell style in xslx - part 2

Another patch for performance improvement for importing cell styles in xslx.

In this sample, there are up to 28380 records of user-defined Xf to import. It
consumes a lot of time. In fact, only 4050 Xf records can be supported in sc
module. 

Thus the patch modifies total count of Xf to import to 4050 in oox module,if
exceeding.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120619] [From Symphony]it's slow to open the simple xslx file

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120619

Yolanda Zhang Ying <tl...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tldyzem@gmail.com

--- Comment #5 from Yolanda Zhang Ying <tl...@gmail.com> ---
Some review comments:
For part1: I think it's ok to do so to reduce import time by limit the useless
operation.
For part2: I think it does not make sense to do so, how could we get the 4050
for max support No.? I don't think for OOXML file import, it has such limit for
AOO to support more than 4050 styles.
Pls help confirm this limitation, thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120619] [From Symphony]it's slow to open the simple xslx file

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120619

bjcheny <co...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #79126|                            |review?
              Flags|                            |

--- Comment #2 from bjcheny <co...@gmail.com> ---
Created attachment 79126
  --> https://issues.apache.org/ooo/attachment.cgi?id=79126&action=edit
patch for performance of importing cell style in xslx

The cause is StyleSheetChanged/PageStyleModified action much too frequently.
Thus the patch disables it, and will only do
StyleSheetChanged/PageStyleModified once after all properties are set.The
changes are:
1. Split the SetOnePropertyValue into SetOnePropertyValueWithoutUpdate and
StyleSheetChanged, 
2. Only invoke StyleSheetChanged once after all properties are set by
SetOnePropertyValueWithoutUpdate .

It can improve the performance of importing cell style significantly.

-- 
You are receiving this mail because:
You are the assignee for the bug.