[GitHub] [tvm] tqchen commented on a change in pull request #9342: Support runtime defined function wrapping of library module packed functions

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #9342:
URL: https://github.com/apache/tvm/pull/9342#discussion_r733835789



##########
File path: src/runtime/library_module.h
##########
@@ -65,6 +65,23 @@ class Library : public Object {
   // This is because we do not need dynamic type downcasting.
 };
 
+/*!
+ * \brief Default virtual functor that provides an interface to
+ * wrap a TVMBackendPackedCFunc. Virtual interface allows derivative
+ * runtime's that utilize a library module to to provide custom
+ * function wrapping. By default WrapPackedFunc is used.
+ */
+class PackedFuncWrapper : public Object {
+ public:

Review comment:
       maybe sufficient to use a std::function that passes in from CreateModuleFromLibrary to reduce the amount of the abstractions and indirections




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org