You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2022/05/14 12:57:32 UTC
svn commit: r1900883 - /subversion/branches/1.14.x/STATUS
Author: danielsh
Date: Sat May 14 12:57:32 2022
New Revision: 1900883
URL: http://svn.apache.org/viewvc?rev=1900883&view=rev
Log:
* STATUS: Nominate r1900882.
Modified:
subversion/branches/1.14.x/STATUS
Modified: subversion/branches/1.14.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1900883&r1=1900882&r2=1900883&view=diff
==============================================================================
--- subversion/branches/1.14.x/STATUS (original)
+++ subversion/branches/1.14.x/STATUS Sat May 14 12:57:32 2022
@@ -39,6 +39,15 @@ Candidate changes:
votes:
+1: rhuijben
+ * r1900882
+ Replace a call to a function deprecated upstream.
+ Justification:
+ No-op on Python 3.2 and newer, but will allow Subversion 1.14.x to be
+ built by future Python 3.12. Note that Python 3.2 was released 9 years
+ before Subversion 1.14.0.
+ Votes:
+ +1: danielsh
+
Veto-blocked changes:
=====================
Re: svn commit: r1900883 - /subversion/branches/1.14.x/STATUS
Posted by Yasuhito FUTATSUKI <fu...@yf.bsdclub.org>.
On 2022/05/15 19:21, Daniel Shahaf wrote:
> Nathan Hartman wrote on Sun, May 15, 2022 at 03:36:05 -0400:
>> On Sat, May 14, 2022 at 8:57 AM <da...@apache.org> wrote:
>>> +++ subversion/branches/1.14.x/STATUS Sat May 14 12:57:32 2022
>>> @@ -39,6 +39,15 @@ Candidate changes:
>>> votes:
>>> +1: rhuijben
>>>
>>> + * r1900882
>>> + Replace a call to a function deprecated upstream.
>>> + Justification:
>>> + No-op on Python 3.2 and newer, but will allow Subversion 1.14.x to be
>>> + built by future Python 3.12. Note that Python 3.2 was released 9 years
>>> + before Subversion 1.14.0.
>>> + Votes:
>>> + +1: danielsh
>>> +
>>
>> Should futatuki's follow-up in r1900890 be added to this nomination?
>
> Per <https://subversion.apache.org/docs/release-notes/1.14#python2>,
> breaking py2 support in a 1.14.x patch release is permitted. Thus,
> we are not required to add r1900890 to this nomination.
I don't want actively dropping ability to build Python 2 bindings
without installed Python 3, on 1.14.x. So I'll nominate r1900890
separately.
> If we do nominate r1900890, here's my +0 for it. (Not +1 because
> I haven't audited all callsites that «import gen_base».)
The change on r1900890 is to restore the behavior before r1900882
only if gen_base.py uses ConfigParser instead of configparser
(i.e. Python < 3).
Cheers,
--
Yasuhito FUTATSUKI <fu...@yf.bsclub.org>
Re: svn commit: r1900883 - /subversion/branches/1.14.x/STATUS
Posted by Nathan Hartman <ha...@gmail.com>.
On Sun, May 15, 2022 at 6:21 AM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
>
> Nathan Hartman wrote on Sun, May 15, 2022 at 03:36:05 -0400:
> > On Sat, May 14, 2022 at 8:57 AM <da...@apache.org> wrote:
> > > +++ subversion/branches/1.14.x/STATUS Sat May 14 12:57:32 2022
> > > @@ -39,6 +39,15 @@ Candidate changes:
> > > votes:
> > > +1: rhuijben
> > >
> > > + * r1900882
> > > + Replace a call to a function deprecated upstream.
> > > + Justification:
> > > + No-op on Python 3.2 and newer, but will allow Subversion 1.14.x to be
> > > + built by future Python 3.12. Note that Python 3.2 was released 9 years
> > > + before Subversion 1.14.0.
> > > + Votes:
> > > + +1: danielsh
> > > +
> >
> > Should futatuki's follow-up in r1900890 be added to this nomination?
>
> Per <https://subversion.apache.org/docs/release-notes/1.14#python2>,
> breaking py2 support in a 1.14.x patch release is permitted. Thus,
> we are not required to add r1900890 to this nomination.
Agreed. I asked just in case you missed it.
> If we do nominate r1900890, here's my +0 for it. (Not +1 because
> I haven't audited all callsites that «import gen_base».)
Understood. Thanks.
> > Also should this reference SVN-4899?
>
> r1900922.
Thanks for adding that.
Cheers,
Nathan
Re: svn commit: r1900883 - /subversion/branches/1.14.x/STATUS
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Sun, May 15, 2022 at 03:36:05 -0400:
> On Sat, May 14, 2022 at 8:57 AM <da...@apache.org> wrote:
> > +++ subversion/branches/1.14.x/STATUS Sat May 14 12:57:32 2022
> > @@ -39,6 +39,15 @@ Candidate changes:
> > votes:
> > +1: rhuijben
> >
> > + * r1900882
> > + Replace a call to a function deprecated upstream.
> > + Justification:
> > + No-op on Python 3.2 and newer, but will allow Subversion 1.14.x to be
> > + built by future Python 3.12. Note that Python 3.2 was released 9 years
> > + before Subversion 1.14.0.
> > + Votes:
> > + +1: danielsh
> > +
>
> Should futatuki's follow-up in r1900890 be added to this nomination?
Per <https://subversion.apache.org/docs/release-notes/1.14#python2>,
breaking py2 support in a 1.14.x patch release is permitted. Thus,
we are not required to add r1900890 to this nomination.
If we do nominate r1900890, here's my +0 for it. (Not +1 because
I haven't audited all callsites that «import gen_base».)
> Also should this reference SVN-4899?
r1900922.
Re: svn commit: r1900883 - /subversion/branches/1.14.x/STATUS
Posted by Nathan Hartman <ha...@gmail.com>.
On Sat, May 14, 2022 at 8:57 AM <da...@apache.org> wrote:
> Author: danielsh
> Date: Sat May 14 12:57:32 2022
> New Revision: 1900883
>
> URL: http://svn.apache.org/viewvc?rev=1900883&view=rev
> Log:
> * STATUS: Nominate r1900882.
>
> Modified:
> subversion/branches/1.14.x/STATUS
>
> Modified: subversion/branches/1.14.x/STATUS
> URL:
> http://svn.apache.org/viewvc/subversion/branches/1.14.x/STATUS?rev=1900883&r1=1900882&r2=1900883&view=diff
>
> ==============================================================================
> --- subversion/branches/1.14.x/STATUS (original)
> +++ subversion/branches/1.14.x/STATUS Sat May 14 12:57:32 2022
> @@ -39,6 +39,15 @@ Candidate changes:
> votes:
> +1: rhuijben
>
> + * r1900882
> + Replace a call to a function deprecated upstream.
> + Justification:
> + No-op on Python 3.2 and newer, but will allow Subversion 1.14.x to be
> + built by future Python 3.12. Note that Python 3.2 was released 9
> years
> + before Subversion 1.14.0.
> + Votes:
> + +1: danielsh
> +
> Veto-blocked changes:
> =====================
>
>
>
Should futatuki's follow-up in r1900890 be added to this nomination?
Also should this reference SVN-4899?
Cheers
Nathan