[GitHub] [ignite] tledkov commented on a diff in pull request #10667: IGNITE-19370 control.sh should be able to use custom SSL factory

["tledkov (via GitHub)" <gi...@apache.org>]

tledkov commented on code in PR #10667:
URL: https://github.com/apache/ignite/pull/10667#discussion_r1190009721


##########
modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommonArgParser.java:
##########
@@ -354,6 +361,11 @@ ConnectionAndSslParameters parseAndValidate(Iterator<String> rawArgIter) {
                         experimentalEnabled = true;
                         break;
 
+                    case CMD_SSL_FACTORY:
+                        sslFactoryCfg = argIter.nextArg("Expected SSL factory config path");

Review Comment:
   What do you think about print warning or throw an exception when defined CMD_SSL_FACTORY and other cmdline SSL options (e.g. CMD_SSL_PROTOCOL, CMD_SSL_PROTOCOL etc)? Could this confuse the user?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org