You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by Eyalb <ey...@gmail.com> on 2010/02/11 11:16:06 UTC

is this a bug ?

Hi,

class VMTransportFactory on method doCompositeConnect line 70

 if (brokerData.getPath() != null) {
                host = data.getPath();
            }

shouldn't it be

if (brokerData.getPath() != null) {
                host = brokerData.getPath();
            }
-- 
View this message in context: http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: is this a bug ?

Posted by Gary Tully <ga...@gmail.com>.

it is there now.

On 18 February 2010 07:27, Eyalb <ey...@gmail.com> wrote:

>
>
> Hi,
>
> I see the fix is for 5.4.0 , why wasn't it fix for 5.3.1 also ?
>
>
> Gary Tully wrote:
> >
> > great, fix applied and recorded in
> > https://issues.apache.org/activemq/browse/AMQ-2607
> > thanks.
> >
> > On 12 February 2010 16:42, Eyalb <ey...@gmail.com> wrote:
> >
> >>
> >>
> >> the url I am using is
> >>
> >>
> >> vm:(broker:(tcp://localhost:61616)/myBroker?persistent=false)
> >>
> >> when to connector starts it says
> >>
> >> 2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://null
> >> Started
> >>
> >> instead of
> >>
> >> 2010-02-12 18:38:24,204 INFO [TransportConnector] Connector
> vm://myBroker
> >> Started
> >>
> >>
> >>
> >> Gary Tully wrote:
> >> >
> >> > can you share your url because it would be great to have a simple test
> >> > case
> >> > to protect the fix?
> >> >
> >> > On 11 February 2010 21:09, Eyalb <ey...@gmail.com> wrote:
> >> >
> >> >>
> >> >> yes
> >> >>
> >> >>
> >> >> Gary Tully wrote:
> >> >> >
> >> >> > that does look odd, are u seeing a problem with a "broker:" url?
> >> >> >
> >> >> > On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:
> >> >> >
> >> >> >>
> >> >> >> Hi,
> >> >> >>
> >> >> >> class VMTransportFactory on method doCompositeConnect line 70
> >> >> >>
> >> >> >>  if (brokerData.getPath() != null) {
> >> >> >>                host = data.getPath();
> >> >> >>            }
> >> >> >>
> >> >> >> shouldn't it be
> >> >> >>
> >> >> >> if (brokerData.getPath() != null) {
> >> >> >>                host = brokerData.getPath();
> >> >> >>            }
> >> >> >> --
> >> >> >> View this message in context:
> >> >> >> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
> >> >> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >> >> >>
> >> >> >>
> >> >> >
> >> >> >
> >> >> > --
> >> >> > http://blog.garytully.com
> >> >> >
> >> >> > Open Source Integration
> >> >> > http://fusesource.com
> >> >> >
> >> >> >
> >> >>
> >> >> --
> >> >> View this message in context:
> >> >> http://old.nabble.com/is-this-a-bug---tp27544304p27554762.html
> >> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > http://blog.garytully.com
> >> >
> >> > Open Source Integration
> >> > http://fusesource.com
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >> http://old.nabble.com/is-this-a-bug---tp27544304p27566212.html
> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> > --
> > http://blog.garytully.com
> >
> > Open Source Integration
> > http://fusesource.com
> >
> >
>
> --
> View this message in context:
> http://old.nabble.com/is-this-a-bug---tp27544304p27635118.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>
>


-- 
http://blog.garytully.com

Open Source Integration
http://fusesource.com

Re: is this a bug ?

Posted by Eyalb <ey...@gmail.com>.


Hi,

I see the fix is for 5.4.0 , why wasn't it fix for 5.3.1 also ?


Gary Tully wrote:
> 
> great, fix applied and recorded in
> https://issues.apache.org/activemq/browse/AMQ-2607
> thanks.
> 
> On 12 February 2010 16:42, Eyalb <ey...@gmail.com> wrote:
> 
>>
>>
>> the url I am using is
>>
>>
>> vm:(broker:(tcp://localhost:61616)/myBroker?persistent=false)
>>
>> when to connector starts it says
>>
>> 2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://null
>> Started
>>
>> instead of
>>
>> 2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://myBroker
>> Started
>>
>>
>>
>> Gary Tully wrote:
>> >
>> > can you share your url because it would be great to have a simple test
>> > case
>> > to protect the fix?
>> >
>> > On 11 February 2010 21:09, Eyalb <ey...@gmail.com> wrote:
>> >
>> >>
>> >> yes
>> >>
>> >>
>> >> Gary Tully wrote:
>> >> >
>> >> > that does look odd, are u seeing a problem with a "broker:" url?
>> >> >
>> >> > On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:
>> >> >
>> >> >>
>> >> >> Hi,
>> >> >>
>> >> >> class VMTransportFactory on method doCompositeConnect line 70
>> >> >>
>> >> >>  if (brokerData.getPath() != null) {
>> >> >>                host = data.getPath();
>> >> >>            }
>> >> >>
>> >> >> shouldn't it be
>> >> >>
>> >> >> if (brokerData.getPath() != null) {
>> >> >>                host = brokerData.getPath();
>> >> >>            }
>> >> >> --
>> >> >> View this message in context:
>> >> >> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
>> >> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>> >> >>
>> >> >>
>> >> >
>> >> >
>> >> > --
>> >> > http://blog.garytully.com
>> >> >
>> >> > Open Source Integration
>> >> > http://fusesource.com
>> >> >
>> >> >
>> >>
>> >> --
>> >> View this message in context:
>> >> http://old.nabble.com/is-this-a-bug---tp27544304p27554762.html
>> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>> >>
>> >>
>> >
>> >
>> > --
>> > http://blog.garytully.com
>> >
>> > Open Source Integration
>> > http://fusesource.com
>> >
>> >
>>
>> --
>> View this message in context:
>> http://old.nabble.com/is-this-a-bug---tp27544304p27566212.html
>> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>>
>>
> 
> 
> -- 
> http://blog.garytully.com
> 
> Open Source Integration
> http://fusesource.com
> 
> 

-- 
View this message in context: http://old.nabble.com/is-this-a-bug---tp27544304p27635118.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: is this a bug ?

Posted by Gary Tully <ga...@gmail.com>.

great, fix applied and recorded in
https://issues.apache.org/activemq/browse/AMQ-2607
thanks.

On 12 February 2010 16:42, Eyalb <ey...@gmail.com> wrote:

>
>
> the url I am using is
>
>
> vm:(broker:(tcp://localhost:61616)/myBroker?persistent=false)
>
> when to connector starts it says
>
> 2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://null
> Started
>
> instead of
>
> 2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://myBroker
> Started
>
>
>
> Gary Tully wrote:
> >
> > can you share your url because it would be great to have a simple test
> > case
> > to protect the fix?
> >
> > On 11 February 2010 21:09, Eyalb <ey...@gmail.com> wrote:
> >
> >>
> >> yes
> >>
> >>
> >> Gary Tully wrote:
> >> >
> >> > that does look odd, are u seeing a problem with a "broker:" url?
> >> >
> >> > On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:
> >> >
> >> >>
> >> >> Hi,
> >> >>
> >> >> class VMTransportFactory on method doCompositeConnect line 70
> >> >>
> >> >>  if (brokerData.getPath() != null) {
> >> >>                host = data.getPath();
> >> >>            }
> >> >>
> >> >> shouldn't it be
> >> >>
> >> >> if (brokerData.getPath() != null) {
> >> >>                host = brokerData.getPath();
> >> >>            }
> >> >> --
> >> >> View this message in context:
> >> >> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
> >> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >> >>
> >> >>
> >> >
> >> >
> >> > --
> >> > http://blog.garytully.com
> >> >
> >> > Open Source Integration
> >> > http://fusesource.com
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >> http://old.nabble.com/is-this-a-bug---tp27544304p27554762.html
> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> > --
> > http://blog.garytully.com
> >
> > Open Source Integration
> > http://fusesource.com
> >
> >
>
> --
> View this message in context:
> http://old.nabble.com/is-this-a-bug---tp27544304p27566212.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>
>


-- 
http://blog.garytully.com

Open Source Integration
http://fusesource.com

Re: is this a bug ?

Posted by Eyalb <ey...@gmail.com>.


the url I am using is


vm:(broker:(tcp://localhost:61616)/myBroker?persistent=false)

when to connector starts it says

2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://null
Started

instead of

2010-02-12 18:38:24,204 INFO [TransportConnector] Connector vm://myBroker
Started



Gary Tully wrote:
> 
> can you share your url because it would be great to have a simple test
> case
> to protect the fix?
> 
> On 11 February 2010 21:09, Eyalb <ey...@gmail.com> wrote:
> 
>>
>> yes
>>
>>
>> Gary Tully wrote:
>> >
>> > that does look odd, are u seeing a problem with a "broker:" url?
>> >
>> > On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:
>> >
>> >>
>> >> Hi,
>> >>
>> >> class VMTransportFactory on method doCompositeConnect line 70
>> >>
>> >>  if (brokerData.getPath() != null) {
>> >>                host = data.getPath();
>> >>            }
>> >>
>> >> shouldn't it be
>> >>
>> >> if (brokerData.getPath() != null) {
>> >>                host = brokerData.getPath();
>> >>            }
>> >> --
>> >> View this message in context:
>> >> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
>> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>> >>
>> >>
>> >
>> >
>> > --
>> > http://blog.garytully.com
>> >
>> > Open Source Integration
>> > http://fusesource.com
>> >
>> >
>>
>> --
>> View this message in context:
>> http://old.nabble.com/is-this-a-bug---tp27544304p27554762.html
>> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>>
>>
> 
> 
> -- 
> http://blog.garytully.com
> 
> Open Source Integration
> http://fusesource.com
> 
> 

-- 
View this message in context: http://old.nabble.com/is-this-a-bug---tp27544304p27566212.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: is this a bug ?

Posted by Gary Tully <ga...@gmail.com>.

can you share your url because it would be great to have a simple test case
to protect the fix?

On 11 February 2010 21:09, Eyalb <ey...@gmail.com> wrote:

>
> yes
>
>
> Gary Tully wrote:
> >
> > that does look odd, are u seeing a problem with a "broker:" url?
> >
> > On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:
> >
> >>
> >> Hi,
> >>
> >> class VMTransportFactory on method doCompositeConnect line 70
> >>
> >>  if (brokerData.getPath() != null) {
> >>                host = data.getPath();
> >>            }
> >>
> >> shouldn't it be
> >>
> >> if (brokerData.getPath() != null) {
> >>                host = brokerData.getPath();
> >>            }
> >> --
> >> View this message in context:
> >> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
> >> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> > --
> > http://blog.garytully.com
> >
> > Open Source Integration
> > http://fusesource.com
> >
> >
>
> --
> View this message in context:
> http://old.nabble.com/is-this-a-bug---tp27544304p27554762.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>
>


-- 
http://blog.garytully.com

Open Source Integration
http://fusesource.com

Re: is this a bug ?

Posted by Eyalb <ey...@gmail.com>.

yes


Gary Tully wrote:
> 
> that does look odd, are u seeing a problem with a "broker:" url?
> 
> On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:
> 
>>
>> Hi,
>>
>> class VMTransportFactory on method doCompositeConnect line 70
>>
>>  if (brokerData.getPath() != null) {
>>                host = data.getPath();
>>            }
>>
>> shouldn't it be
>>
>> if (brokerData.getPath() != null) {
>>                host = brokerData.getPath();
>>            }
>> --
>> View this message in context:
>> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
>> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>>
>>
> 
> 
> -- 
> http://blog.garytully.com
> 
> Open Source Integration
> http://fusesource.com
> 
> 

-- 
View this message in context: http://old.nabble.com/is-this-a-bug---tp27544304p27554762.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: is this a bug ?

Posted by Gary Tully <ga...@gmail.com>.

that does look odd, are u seeing a problem with a "broker:" url?

On 11 February 2010 10:16, Eyalb <ey...@gmail.com> wrote:

>
> Hi,
>
> class VMTransportFactory on method doCompositeConnect line 70
>
>  if (brokerData.getPath() != null) {
>                host = data.getPath();
>            }
>
> shouldn't it be
>
> if (brokerData.getPath() != null) {
>                host = brokerData.getPath();
>            }
> --
> View this message in context:
> http://old.nabble.com/is-this-a-bug---tp27544304p27544304.html
> Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
>
>


-- 
http://blog.garytully.com

Open Source Integration
http://fusesource.com